Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7704

Remove use of #pragma comment (lib, "IPHLPAPI.lib").

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • None
    • None
    • Windows

    Description

      Commits 0a1e94d84, 5a7c8d8ef, and f7f661525 introduced the pattern of linking to a Windows system library with the #pragma comment(lib, "IPHLPAPI.lib"), instead of adding the library to the correct place in the CMake build system.

      While this works, we should be consistent in the way we link to libraries, so this code should be removed and IPHLPAPI.lib should be added to stout's LFLAGS.

      Attachments

        Activity

          People

            andschwa Andrew Schwartzmeyer
            andschwa Andrew Schwartzmeyer
            Joseph Wu Joseph Wu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: