Details
-
Task
-
Status: Reviewable
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
Description
This JIRA tracks the implementation of this TODO:
// TODO(bmahler): Check invariants between old and new allocations.
// Namely, the roles and quantities of resources should be the same!
// Otherwise, we need to ensure we re-calculate the shares, as
// is being currently done, for safety.
After this check, we can remove the line that sets the sorter to be dirty after this call and we can avoid an unnecessary sort.
Note that the shared resources feature currently assumes the invariants.