[MESOS-6428] Mesos containerizer helper function signalSafeWriteStatus is not AS-Safe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.5.0
• Component/s: containerization
• Labels: newbie tech-debt
• Sprint: Mesosphere Sprint 63
• Story Points: 3
• Assignee: Andrei Budnik
• Reporter: Benjamin Bannier
• Shepherd: James Peach
• Created: 20/Oct/16 14:49
• Updated: 12/Sep/17 01:51
• Resolved: 07/Sep/17 05:32

Description

In src/slave/containerizer/mesos/launch.cpp a helper function signalSafeWriteStatus is defined. Its name seems to suggest that this function is safe to call in e.g., signal handlers, and it is used in this file's signalHandler for exactly that purpose.

Currently this function is not AS-Safe since it e.g., allocates memory via construction of string instances, and might destructively modify errno.

We should clean up this function to be in fact AS-Safe.