[MESOS-4331] git commit-msg hook completely breaks fixup commits.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Labels: mesosphere
• Story Points: 1
• Assignee: Andrew Schwartzmeyer
• Reporter: Benjamin Bannier
• Shepherd: Alex R
• Created: 11/Jan/16 13:30
• Updated: 26/Nov/18 12:22
• Resolved: 26/Nov/18 12:22

Description

https://reviews.apache.org/r/41586/ added a git hook to check the commit message format. This completely breaks fixup commits which can be created with

% git commit --fixup=$SHA1 

The resulting commit message will then be the one of $SHA1, but prefixed with fixup! (followed by a literal space). Tools like git rebase can automatically use these to e.g., squash matching commits like

% git rebase -i origin/master --autosquash

Here all commits for e.g., $SHA1 would be grouped together and squash automatically which is valuable when working on reviews.

We should find a way to reenable such functionality; otherwise we risk that developers completely disable this hook.