Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
-
None
Description
We've accumulated a lot of cruft around amount of memory/disk.
via benh: "It's really time for a Bytes/Kilobytes/Megabytes/Gigabytes struct. Unlike Duration, maybe it makes sense to just create a single Bytes class as the "base", or maybe call it Bits? Not sure if Size or Data are descriptive enough."
My thoughts:
Size: typically refers to number of things (list::size, vector::size, map::size, ...)
Data: typically refers to the data itself, rather than size (char* data, string data, ...)
Bytes: although works fine at the unit level, like Seconds, seems odd as the base class (makes me think of actual byte data, rather than # of bytes).
Duration worked nicely to avoid doing Amount<Time>, however in this case it's tricker to avoid Amount<Data> ( https://github.com/twitter/commons/tree/master/src/java/com/twitter/common/quantity )
I'd go with Bytes or Bits, preferably Bytes.