[#MATH-267] Need a digamma function

Commons Math

Need a digamma function

Created: 23/May/09 11:40 PM Updated: 07/Aug/09 09:15 AM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

2.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
Adds_digamma_function.patch	2009-05-24 04:37 AM	Ted Dunning	5 kB
Adds_trigamma_function,_improves_comments.patch	2009-05-24 06:39 AM	Ted Dunning	6 kB
digamma.tgz	2009-05-23 11:41 PM	Ted Dunning	12 kB

Resolution Date:

25/May/09 01:22 PM

Description

« Hide

A mahout summer of code student needed a digamma function with Apache permissions so I wrote one. It includes test cases, correct copyright and seems to work well. I don't know where in commons math this would go so I figured I would post this and ask for advice.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Ted Dunning added a comment - 23/May/09 11:41 PM

Source code for implementation.

Ted Dunning made changes - 23/May/09 11:41 PM

Field	Original Value	New Value
Attachment		digamma.tgz [ 12408892 ]

[ Permlink | « Hide ]

Phil Steitz added a comment - 24/May/09 02:45 AM

Thanks! Have a look at the o.a.c.m.special package, There is a Gamma class there that could use this,

[ Permlink | « Hide ]

Ted Dunning added a comment - 24/May/09 04:37 AM

Here is a patch that integrates the digamma function into the normal commons math structure.

Ted Dunning made changes - 24/May/09 04:37 AM

Attachment

Adds_digamma_function.patch [ 12408900 ]

[ Permlink | « Hide ]

Ted Dunning added a comment - 24/May/09 04:40 AM

I have left this open rather than resolve it because I don't see a "patch available" state such as I am used to on Hadoop and related projects.

The patch is available and should be ready for committing (subject to committers approving, of course).

Repository	Revision	Date	User	Message
ASF	#778091	Sun May 24 06:03:19 UTC 2009	psteitz	Added digamma function. JIRA: ~~MATH-267~~ Contributed by Ted Dunning
				Files Changed
				MODIFY /commons/proper/math/trunk/src/test/org/apache/commons/math/special/GammaTest.java MODIFY /commons/proper/math/trunk/src/site/xdoc/changes.xml MODIFY /commons/proper/math/trunk/src/java/org/apache/commons/math/special/Gamma.java

[ Permlink | « Hide ]

Phil Steitz added a comment - 24/May/09 06:05 AM

Patch applied in r778091 with only minor changes. thanks!

Phil Steitz made changes - 24/May/09 06:05 AM

Resolution		Fixed [ 1 ]
Fix Version/s		2.0 [ 12312686 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Ted Dunning added a comment - 24/May/09 06:37 AM

The previous patch lost some comments from my original.

Also, I added a trigramma function.

Ted Dunning made changes - 24/May/09 06:37 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

[ Permlink | « Hide ]

Ted Dunning added a comment - 24/May/09 06:39 AM

I improved the javadoc and added a trigamma function with associated tests.

This patch is relative to current trunk which already contains the digamma function that Phil just committed.

Ted Dunning made changes - 24/May/09 06:39 AM

Attachment

Adds_trigamma_function,_improves_comments.patch [ 12408901 ]

Repository	Revision	Date	User	Message
ASF	#778416	Mon May 25 13:20:07 UTC 2009	psteitz	Added trigamma, javadoc fixes for digamma. JIRA: ~~MATH-267~~. Patched by Ted Dunning.
				Files Changed
				MODIFY /commons/proper/math/trunk/src/test/org/apache/commons/math/special/GammaTest.java MODIFY /commons/proper/math/trunk/src/java/org/apache/commons/math/special/Gamma.java

[ Permlink | « Hide ]

Phil Steitz added a comment - 25/May/09 01:22 PM

Second patch applied. I made a few small changes to the javadoc to match the style of [math].

Thanks!

Phil Steitz made changes - 25/May/09 01:22 PM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Luc Maisonobe added a comment - 07/Aug/09 09:15 AM

closing resolved issue for 2.0 release

Luc Maisonobe made changes - 07/Aug/09 09:15 AM

Status

Resolved [ 5 ]

Closed [ 6 ]