[MAPREDUCE-770] org.apache.hadoop.tools.TestCopyFiles may leave junk files when an assertion fails

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: test
• Assignee: Unassigned
• Reporter: Dick King
• Created: 17/Jul/09 21:42
• Updated: 23/Jul/14 20:00
• Resolved: 23/Jul/14 20:00

Description

In most of the testXxxYyyZzz methods, the code runs:

preliminaries

ToolRunner( ..., new String[]

{ local and DFS filenames and more filenames }

);

assertMaybe("this result stank", conditions);
assertMaybe("this other result stank", conditions);

deldir(deletee's name);
deldir(second deletee's name);

The assertMaybe's throw AssertionFailedError . That's what they DO. Shouldn't this stuff be protected with a try ... finally construct?