[MAPREDUCE-7007] Add LOG.isDebugEnabled() guard for each LOG.debug()

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Mehran Hassani
• Created: 13/Nov/17 20:18
• Updated: 13/Nov/17 21:37

Description

I am conducting research on log related bugs. I tried to make a tool to fix repetitive yet simple patterns of bugs that are related to logs. In these files, there are debug level logging statements containing multiple string concatenation without the if statement before them:

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java, LOG.debug("splits["+j+"]="splits[j]" count=" + count);, 123
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestTextInputFormat.java, LOG.debug("splits["+j+"]="splits[j]" count=" + count);, 137
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestTextInputFormat.java, LOG.debug("splits[" + j + "]=" + splits[j] + " count=" + counter);, 254
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestTextInputFormat.java, LOG.debug("splits["+j+"]="splits[j]" count=" + counter);, 315
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestMRKeyValueTextInputFormat.java, LOG.debug("splits[" + j + "]=" + splits.get(j) +" count=" + count);, 146
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestMRKeyValueTextInputFormat.java, LOG.debug("splits["+j+"]="splits.get(j)" count=" + count);, 244

Would you be interested in adding the if before these logging statements?