[MAPREDUCE-5752] Potential invalid iterator in NMClientImpl#cleanupRunningContainers()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Invalid
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 11/Feb/14 21:12
• Updated: 21/Jul/16 06:20
• Resolved: 21/Jul/16 06:20

Description

In cleanupRunningContainers() :

    for (StartedContainer startedContainer : startedContainers.values()) {
      try {
        stopContainer(startedContainer.getContainerId(),
            startedContainer.getNodeId());

Removal of container is done in removeStartedContainer():

    startedContainers.remove(container.containerId);

This may result in invalid iterator for the loop on startedContainers.values()