[MAPREDUCE-5739] DirectoryCollection#createNonExistentDirs() may use an invalid iterator

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 04/Feb/14 00:20
• Updated: 21/Jul/16 06:22
• Resolved: 21/Jul/16 06:22

Description

Here is related code:

    for (final String dir : localDirs) {
      try {
        createDir(localFs, new Path(dir), perm);
      } catch (IOException e) {
        LOG.warn("Unable to create directory " + dir + " error " +
            e.getMessage() + ", removing from the list of valid directories.");
        localDirs.remove(dir);

Call to localDirs.remove() modifies Iterable "localDirs" which invalidates the iterator.