[MAPREDUCE-4239] gridmix has 11 findbugs warnings

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 2.0.0-alpha
• Component/s: contrib/gridmix
• Target Version/s: 2.0.0-alpha
• Assignee: Unassigned
• Reporter: Thomas Graves
• Created: 09/May/12 21:02
• Updated: 02/May/13 02:29
• Resolved: 26/Mar/13 20:42

Description

jira MAPREDUCE-3543 is mavenizing gridmix. I found that gridmix has 11 findbugs warnings while doing that jira that should be fixed or have excludes added for them.

Code Warning
Se org.apache.hadoop.mapred.gridmix.GridmixRecord$Comparator implements Comparator but not Serializable
Malicious code vulnerability Warnings

Code Warning
EI org.apache.hadoop.mapred.gridmix.SleepJob$SleepSplit.getLocations() may expose internal representation by returning SleepJob$SleepSplit.locations
EI2 new org.apache.hadoop.mapred.gridmix.SleepJob(Configuration, long, JobStory, Path, UserGroupInformation, int, int, String[]) may expose internal representation by storing an externally mutable object into SleepJob.hosts
EI2 new org.apache.hadoop.mapred.gridmix.SleepJob$SleepSplit(int, long, long[], int, String[]) may expose internal representation by storing an externally mutable object into SleepJob$SleepSplit.locations
EI2 new org.apache.hadoop.mapred.gridmix.SleepJob$SleepSplit(int, long, long[], int, String[]) may expose internal representation by storing an externally mutable object into SleepJob$SleepSplit.reduceDurations
MS org.apache.hadoop.mapred.gridmix.emulators.resourceusage.TotalHeapUsageEmulatorPlugin.ONE_MB isn't final but should be
MS org.apache.hadoop.mapred.gridmix.emulators.resourceusage.TotalHeapUsageEmulatorPlugin$DefaultHeapUsageEmulator.heapSpace isn't final but should be
Multithreaded correctness Warnings

Code Warning
JLM Synchronization performed on java.util.concurrent.LinkedBlockingQueue in org.apache.hadoop.mapred.gridmix.JobMonitor.add(Statistics$JobStats)
JLM Synchronization performed on java.util.concurrent.BlockingQueue in org.apache.hadoop.mapred.gridmix.JobMonitor$MonitorThread.run()
JLM Synchronization performed on java.util.concurrent.BlockingQueue in org.apache.hadoop.mapred.gridmix.JobMonitor$MonitorThread.run()
Dodgy Warnings

Code Warning
REC Exception is caught when Exception is not thrown in org.apache.hadoop.mapred.gridmix.ExecutionSummarizer.processJobState(Statistics$JobStats)

Issue Links

• depends upon: MAPREDUCE-3543 Mavenize Gridmix.
• duplicates: MAPREDUCE-5098 Fix findbugs warnings in gridmix