[MAPREDUCE-2548] Log improvements in DBOutputFormat.java and CounterGroup.java

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 2.0.0-alpha
• Assignee: Devaraj Kavali
• Reporter: Devaraj Kavali
• Created: 31/May/11 05:40
• Updated: 08/Dec/21 11:20
• Resolved: 17/Jan/13 13:07

Description

1. Instead of the printing the stack trace on the console, It can be logged.

DBOutputFormat.java

    
public void write(K key, V value) throws IOException {
      try {
        key.write(statement);
        statement.addBatch();
      } catch (SQLException e) {
        e.printStackTrace();
      }
    }

2. Missing resource information can be logged.

CounterGroup .java

protected CounterGroup(String name) {
    this.name = name;
    try {
      bundle = getResourceBundle(name);
    }
    catch (MissingResourceException neverMind) {
    }
    displayName = localize("CounterGroupName", name);
  }


  private String localize(String key, String defaultValue) {
    String result = defaultValue;
    if (bundle != null) {
      try {
        result = bundle.getString(key);
      }
      catch (MissingResourceException mre) {
      }
    }
    return result;
  }

Issue Links

• is superceded by: MAPREDUCE-7368 DBOutputFormat.DBRecordWriter#write must throw exception when it fails