Job and JobControl classes should return interfaces rather than implementations

• Key: MAPREDUCE-245
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Tom White
• Reporter: Tom White
• Fix Version/s: 0.21.0

Description

See HADOOP-2202 and HADOOP-2268 for background on this. I am creating a new issue, since the previous two did not fix the problem, and it can be addressed when we make non backwards compatible changes to Hadoop (perhaps along with HADOOP-1230).

Comments

[Tom White]

A patch for the new job control API in the mapreduce package. The mapred package is left unchanged.

[Amareshwari Sriramadasu]

Patch looks good.

[Chris Douglas]

The patch does not compile (JobControl::castToJobList)

[Tom White]

Here's a new patch which compiles, and passes the old and new job control tests (last time I thought I had successfully run the new tests, but clearly I hadn't).

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12412070/MAPREDUCE-245.patch
against trunk revision 791909.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/362/console

This message is automatically generated.

[Chris Douglas]

Overlapping change conflicts; attaching trivial merge

[Chris Douglas]

I committed this. Thanks, Tom!

[Hudson]

Integrated in Hadoop-Mapreduce-trunk #29 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/29/)