[MAPREDUCE-1166] SerialUtils.cc: dynamic allocation of arrays based on runtime variable is not portable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Assignee: Allen Wittenauer
• Reporter: Allen Wittenauer
• Created: 16/Sep/09 22:36
• Updated: 02/Nov/11 17:48
• Resolved: 02/Nov/11 17:48

Description

In SerialUtils.cc, the following code appears:

int len;
if (b < -120)

{ negative = true; len = -120 - b; }

else

{ negative = false; len = -112 - b; }

uint8_t barr[len];

as far as I'm aware, this is not legal in ANSI C and will be rejected by ANSI compliant compilers. Instead, this should be malloc()'d based upon the size of len and free()'d later.