[MAHOUT-52] Standardize on java.util.logging, Commons Logging, log4j?

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.1
• Assignee: Unassigned
• Reporter: Sean R. Owen
• Created: 10/May/08 19:39
• Updated: 21/May/11 03:24
• Resolved: 14/May/08 23:04

Description

I see the log4j and Commons Logging .jars in the lib/ directory. log4j isn't used; Commons Logging is used in one class (Parametered). My code just used java.util.logging directly.

I figure we should standardize on one approach to logging. I personally think they're all just about the same; the only real best practice is using one system.

I have always just used java.util.logging since it is built into Java 1.4+. Commons Logging offers an extra layer of abstraction and lets you switch between java.util.logging and log4j underneath. That's cool, but I've not found it compelling enough to want to add another layer and another .jar file.

But, I guess log4j is present because hadoop uses it directly? The .jar seems to have a dependency on it.

In that case maybe we are better off using Commons Logging to let us integrate with log4j logging that Hadoop uses, and leave open the possibility of other callers using java.util.logging underneath.

If that's cool I can switch my code to use Commons Logging.