[MADLIB-1276] Marginal Regression summary tables are lost after the end of session.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: v1.15.1
• Component/s: Module: Logistic Regression
• Assignee: Unassigned
• Reporter: Orhan Kislal
• Created: 24/Sep/18 12:33
• Updated: 15/Oct/18 18:12
• Resolved: 15/Oct/18 18:12

Description

margins_logregr function creates 2 output tables. The model table is created in the correct schema but the summary table is left in the pg_temp schema, which means that at the end of the session, the summary table will be lost. Passing an output name with a schema does not work either and it throws the following error. 

ERROR:  spiexceptions.FeatureNotSupported: cannot move objects into or out of temporary schemas

This is caused by the way tables are created in margins_logregr. The function creates the model and the summary in a temp schema. The model table is used to create the output table. The summary, on the other hand, does not need much processing and simply gets renamed. However, the generic rename_table function does not change the schema unless there is a schema in the new name.

Copying the contents, instead of renaming the summary table, seems like an easy solution. Since this is just a summary table, the contents should be limited in size and this change should not decrease the performance.

Issue Links

• links to: GitHub Pull Request #330