[MADLIB-1078] Skip install check for PMML modules

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: v1.11
• Component/s: Build System
• Assignee: Unassigned
• Reporter: Frank McQuillan
• Created: 07/Mar/17 01:43
• Updated: 31/May/18 19:28
• Resolved: 14/Apr/17 21:35

Description

Comments from Ed Espino on 1.10 RC-2 review on thread
https://mail-archives.apache.org/mod_mbox/incubator-madlib-user/201703.mbox/%3CCAHAuQDzarS7K4u-rOsLLhbwSHCyFn5cKSyjLinE%2BZ%3DjSpU59qw%40mail.gmail.com%3E

BUILD, INSTALL and INSTALL-CHECK

I was able to build the package and successfully ran MADlib
install-check against PostgreSQL 9.6.2.

Issue: There is no obvious reference to the PostgreSQL libxml
       dependency in dev documentation. The madpack install-check
       has failures (see below) if "--with-libxml" configure
       option is not specified for PostgreSQL.

       install-check errors encountered due to PostgreSQL
       configuration without "--with-libxml" option:

         psql:/tmp/madlib.0UIPlZ/pmml/test/table_to_pmml.sql_in.tmp:73: ERROR:  unsupported XML feature
         DETAIL:  This functionality requires the server to be built with libxml support.
         HINT:  You need to rebuild PostgreSQL using --with-libxml.
         CONTEXT:  while creating return value
         PL/Python function "pmml"

Story

As a MADlib installer, I want IC tests that use lib-xml to be skipped, so that my install is clean and I do not have to wonder if there is a problem. For now this is only PMML modules, so just skip those ICs.

More: if at PMML export is called that requires lib-xml, then it will fail with a run-time db error which is fine. This is not a commonly used function.

Acceptance:

1) madpack install succeeds and IC passes even tho PG does not have libxml installed

Issue Links

• links to: GitHub Pull Request #115
• links to: GitHub Pull Request #271