[LUCENE-9796] fix SortedDocValues to no longer extend BinaryDocValues

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 21/Feb/21 16:05
• Updated: 28/Aug/22 16:16
• Resolved: 15/Mar/21 03:12

Description

SortedDocValues give ordinals and a way to derefence ordinal as a byte[]

But currently they extend BinaryDocValues, which allows directly calling binaryValue().

This allows them to act as a "slow" BinaryDocValues, but it is a performance trap, especially now that terms bytes may be block-compressed (LUCENE-9663).

I think this should be detangled to prevent performance traps like LUCENE-9795: SortedDocValues shouldn't have the trappy inherited binaryValue() method that implicitly derefs the ord for the doc, then the term bytes for the ord.

Issue Links

• relates to: SOLR-15261 SortedDocValues no longer extends BinaryDocValues