[LUCENE-8657] CharsRef.compareTo() should always be in UTF-8 order

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Fix Version/s: 8.0
• Lucene Fields: New
• Assignee: Alan Woodward
• Reporter: Alan Woodward
• Created: 24/Jan/19 10:19
• Updated: 28/Aug/22 15:40
• Resolved: 29/Jan/19 12:13

Description

CharsRef.compareTo() currently directly compares byte values.  However, everywhere that CharsRef objects are compared in the codebase instead uses the deprecated UTF16SortedAsUTF8Comparator static comparator.  We should just reimplement compareTo() to use UTF-8 comparisons instead, and remove the deprecated methods.