[LUCENE-8046] Redundant assign values to one variable continuously, which makes the first assignment redundant and useless

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 7.0.1
• Component/s: modules/analysis
• Labels: performance

Environment

Ubuntu 14.04.5 LTS

• Lucene Fields: Patch Available
• Assignee: Unassigned
• Reporter: song
• Created: 10/Nov/17 02:17
• Updated: 28/Aug/22 15:21
• Resolved: 28/Nov/17 10:49

Description

Our static code analysis tool has scanned the codebase of Lucene 7.0.1, and find 29 cases, that developers reassigned values to a variable continuously.

For example, the following code from file:
analysis/common/src/java/org/tartarus/snowball/ext/CatalanStemmer.java

cursor=limit - v_5;
cursor=limit_backward;

In the above code snippet, the second statement makes the first one redundant and useless.
There are 29 cases in total in the codebase of Lucene.