[LUCENE-7909] Issue with holes in polygons

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Component/s: modules/spatial3d
• Lucene Fields: New
• Assignee: Karl Wright
• Reporter: Ignacio Vera
• Created: 18/Jul/17 11:27
• Updated: 28/Aug/22 15:17
• Resolved: 18/Jul/17 12:34

Description

Hi,

It seems the behavior of adding holes to polygons is not behaving well. It seems it is all related to the following method:

/** Check if a point is within the provided holes.
*@param point point to check.
*@return true if the point is within any of the holes.
*/
protected boolean isWithinHoles(final GeoPoint point) {
if (holes != null) {
for (final GeoPolygon hole : holes) {
if (!hole.isWithin(point))

{ return true; }

}
}
return false;
}

The negation in the if clause is wrong. This affects two classes, GeoConvexPolygon and GeoConcavePolygon. I have ready a patch if you think it should be corrected.

Thanks,

I.