[LUCENE-7789] replace & forbid "new FileInputStream" and "new FileOutputStream" with Files.newInputStream & Files.newOutputStream

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Chris M. Hostetter
• Created: 19/Apr/17 16:48
• Updated: 28/Aug/22 15:13

Description

I haven't looked into the details of this much, but saw these links today and thought it would be worth opening a jira for discussion...

• https://dzone.com/articles/fileinputstream-fileoutputstream-considered-harmful
• https://issues.jenkins-ci.org/browse/JENKINS-42934
• https://bugs.openjdk.java.net/browse/JDK-8080225

The crux of the issue being that the "FileInputStream" and "FileOutputStream" classes have finalizer methods with GC overhead that can be avoided using Files.newInputStream and Files.newOutputStream in their place.

This seems like it would make these methods good candidates for forbidding in lucene/solr (if possible).