[LUCENE-6565] Is it ok for IndexWriter.prepareCommit to be an NRT-visible change?

• Type: Task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Adrien Grand
• Created: 15/Jun/15 09:23
• Updated: 28/Aug/22 14:35

Description

Because of LUCENE-6523, IndexWriter.prepareCommit is now an NRT-visible change. For instance the following test would fail:

Directory dir = newDirectory();
IndexWriter w = new IndexWriter(dir, new IndexWriterConfig(new MockAnalyzer(random())));
w.addDocument(new Document());
DirectoryReader reader = DirectoryReader.open(w, true);
assertNull(DirectoryReader.openIfChanged(reader)); // ok
w.prepareCommit();
assertNull(DirectoryReader.openIfChanged(reader)); // fails