Issue Details (XML | Word | Printable)

Key: LUCENE-584
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Mark Miller
Reporter: Peter Schäfer
Votes: 11
Watchers: 4
Operations

If you were logged in you would be able to see more operations.
Lucene - Java

Decouple Filter from BitSet

Created: 31/May/06 06:47 PM   Updated: 25/Sep/09 04:23 PM
Return to search
Component/s: Search
Affects Version/s: 2.1
Fix Version/s: 2.9

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works bench-diff.txt 2007-04-08 03:59 AM Doron Cohen 8 kB
Text File Licensed for inclusion in ASF works bench-diff.txt 2007-04-05 09:33 PM Otis Gospodnetic 7 kB
Text File Licensed for inclusion in ASF works CHANGES.txt.patch 2008-02-03 08:57 AM Paul Elschot 0.7 kB
Text File Licensed for inclusion in ASF works ContribQueries20080111.patch 2008-01-11 02:06 PM Paul Elschot 2 kB
Text File Licensed for inclusion in ASF works lucene-584-take2.patch 2007-12-03 05:53 AM Michael Busch 52 kB
Text File Licensed for inclusion in ASF works lucene-584-take3-part1.patch 2008-01-10 08:04 AM Michael Busch 37 kB
Text File Licensed for inclusion in ASF works lucene-584-take3-part2.patch 2008-01-10 08:04 AM Michael Busch 77 kB
Text File Licensed for inclusion in ASF works lucene-584-take4-part1.patch 2008-01-11 08:58 AM Michael Busch 39 kB
Text File Licensed for inclusion in ASF works lucene-584-take4-part2.patch 2008-01-11 08:58 AM Michael Busch 77 kB
Text File Licensed for inclusion in ASF works lucene-584-take5-part1.patch 2008-02-01 03:54 AM Michael Busch 47 kB
Text File Licensed for inclusion in ASF works lucene-584-take5-part2.patch 2008-02-01 03:54 AM Michael Busch 76 kB
Text File Licensed for inclusion in ASF works lucene-584.patch 2007-11-28 09:25 AM Michael Busch 34 kB
Text File Licensed for inclusion in ASF works Matcher-20070905-2default.patch 2007-09-05 09:27 PM Paul Elschot 75 kB
Text File Licensed for inclusion in ASF works Matcher-20070905-3core.patch 2007-09-05 09:27 PM Paul Elschot 18 kB
Text File Licensed for inclusion in ASF works Matcher-20071122-1ground.patch 2007-11-22 06:33 PM Paul Elschot 32 kB
Zip Archive Licensed for inclusion in ASF works Some Matchers.zip 2006-09-04 09:02 PM Eks Dev 9 kB
Text File Licensed for inclusion in ASF works Test20080111.patch 2008-01-11 08:48 PM Paul Elschot 6 kB
Issue Links:
Reference
 

Resolution Date: 22/Aug/09 09:18 PM


 Description  « Hide
package org.apache.lucene.search;

public abstract class Filter implements java.io.Serializable 
{
  public abstract AbstractBitSet bits(IndexReader reader) throws IOException;
}

public interface AbstractBitSet 
{
  public boolean get(int index);
}

It would be useful if the method =Filter.bits()= returned an abstract interface, instead of =java.util.BitSet=.

Use case: there is a very large index, and, depending on the user's privileges, only a small portion of the index is actually visible.
Sparsely populated =java.util.BitSet=s are not efficient and waste lots of memory. It would be desirable to have an alternative BitSet implementation with smaller memory footprint.

Though it is possibly to derive classes from =java.util.BitSet=, it was obviously not designed for that purpose.
That's why I propose to use an interface instead. The default implementation could still delegate to =java.util.BitSet=.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Paul Elschot made changes - 27/Jun/06 04:47 AM
Field Original Value New Value
Attachment HitCollector-20060626.patch [ 12335947 ]
Paul Elschot made changes - 27/Jun/06 04:49 AM
Attachment Searcher-20060626.patch [ 12335949 ]
Paul Elschot made changes - 27/Jun/06 04:52 AM
Attachment MatchCollector.java [ 12335951 ]
Paul Elschot made changes - 27/Jun/06 04:53 AM
Attachment Matcher.java [ 12335953 ]
Paul Elschot made changes - 27/Jun/06 04:55 AM
Attachment Scorer-20060626.patch [ 12335954 ]
Paul Elschot made changes - 27/Jun/06 04:58 AM
Attachment Filter-20060626.patch [ 12335956 ]
Paul Elschot made changes - 27/Jun/06 05:00 AM
Attachment IndexSearcher-20060626.patch [ 12335957 ]
Paul Elschot made changes - 27/Jun/06 05:02 AM
Attachment BitsMatcher.java [ 12335958 ]
Paul Elschot made changes - 27/Jun/06 05:05 AM
Attachment SortedVIntList.java [ 12335959 ]
Paul Elschot made changes - 27/Jun/06 05:07 AM
Attachment TestSortedVIntList.java [ 12335960 ]
Paul Elschot made changes - 27/Jun/06 05:09 AM
Link This issue relates to LUCENE-328 [ LUCENE-328 ]
Paul Elschot made changes - 28/Jun/06 02:19 PM
Attachment Searchable-20060628.patch [ 12336045 ]
Attachment Searcher-20060628.patch [ 12336046 ]
Attachment HitCollector-20060628.patch [ 12336044 ]
Paul Elschot made changes - 28/Jun/06 02:20 PM
Attachment IndexSearcher-20060628.patch [ 12336049 ]
Attachment Filter-20060628.patch [ 12336048 ]
Attachment Scorer-20060628.patch [ 12336047 ]
Paul Elschot made changes - 28/Jun/06 02:22 PM
Attachment SortedVIntList.java [ 12336052 ]
Attachment Matcher.java [ 12336050 ]
Attachment MatchCollector.java [ 12336051 ]
Paul Elschot made changes - 28/Jun/06 02:23 PM
Attachment Filter-20060626.patch [ 12335956 ]
Paul Elschot made changes - 28/Jun/06 02:23 PM
Attachment HitCollector-20060626.patch [ 12335947 ]
Paul Elschot made changes - 28/Jun/06 02:23 PM
Attachment IndexSearcher-20060626.patch [ 12335957 ]
Paul Elschot made changes - 28/Jun/06 02:24 PM
Attachment MatchCollector.java [ 12335951 ]
Paul Elschot made changes - 28/Jun/06 02:24 PM
Attachment Matcher.java [ 12335953 ]
Paul Elschot made changes - 28/Jun/06 02:25 PM
Attachment Scorer-20060626.patch [ 12335954 ]
Paul Elschot made changes - 28/Jun/06 02:25 PM
Attachment Searcher-20060626.patch [ 12335949 ]
Paul Elschot made changes - 28/Jun/06 02:25 PM
Attachment SortedVIntList.java [ 12335959 ]
Paul Elschot made changes - 29/Jun/06 04:08 AM
Attachment BitsMatcher.java [ 12336093 ]
Attachment TestSortedVIntList.java [ 12336095 ]
Attachment SortedVIntList.java [ 12336094 ]
Paul Elschot made changes - 29/Jun/06 04:08 AM
Attachment BitsMatcher.java [ 12335958 ]
Paul Elschot made changes - 29/Jun/06 04:08 AM
Attachment SortedVIntList.java [ 12336052 ]
Paul Elschot made changes - 29/Jun/06 04:09 AM
Attachment TestSortedVIntList.java [ 12335960 ]
Paul Elschot made changes - 30/Aug/06 07:31 PM
Attachment Matcher20060830.patch [ 12339895 ]
Paul Elschot made changes - 30/Aug/06 08:52 PM
Attachment Matcher20060830b.patch [ 12339901 ]
Paul Elschot made changes - 30/Aug/06 09:32 PM
Attachment Matcher20060830.patch [ 12339895 ]
Eks Dev made changes - 04/Sep/06 09:02 PM
Attachment Some Matchers.zip [ 12340162 ]
Paul Elschot made changes - 01/Nov/06 07:59 PM
Attachment SortedVIntList.java [ 12336094 ]
Paul Elschot made changes - 01/Nov/06 08:01 PM
Attachment SortedVIntList.java [ 12344133 ]
Paul Elschot made changes - 26/Feb/07 08:03 PM
Attachment Matcher20070226.patch [ 12352057 ]
Paul Elschot made changes - 26/Feb/07 08:04 PM
Attachment Matcher20060830b.patch [ 12339901 ]
Otis Gospodnetic made changes - 05/Apr/07 09:33 PM
Attachment bench-diff.txt [ 12355042 ]
Doron Cohen made changes - 08/Apr/07 03:59 AM
Attachment bench-diff.txt [ 12355127 ]
Paul Elschot made changes - 25/Jul/07 10:21 AM
Attachment DefaultMatcher20070725.patch [ 12362506 ]
Paul Elschot made changes - 25/Jul/07 06:12 PM
Attachment Matcher-default20070725.patch [ 12362545 ]
Attachment Matcher-core20070725.patch [ 12362546 ]
Attachment Matcher-ground20070725.patch [ 12362544 ]
Paul Elschot made changes - 25/Jul/07 06:13 PM
Attachment Matcher20070226.patch [ 12352057 ]
Paul Elschot made changes - 25/Jul/07 06:14 PM
Attachment DefaultMatcher20070725.patch [ 12362506 ]
Paul Elschot made changes - 25/Jul/07 06:15 PM
Attachment BitsMatcher.java [ 12336093 ]
Paul Elschot made changes - 25/Jul/07 06:15 PM
Attachment Filter-20060628.patch [ 12336048 ]
Paul Elschot made changes - 25/Jul/07 06:15 PM
Attachment HitCollector-20060628.patch [ 12336044 ]
Paul Elschot made changes - 25/Jul/07 06:15 PM
Attachment IndexSearcher-20060628.patch [ 12336049 ]
Paul Elschot made changes - 25/Jul/07 06:15 PM
Attachment MatchCollector.java [ 12336051 ]
Paul Elschot made changes - 25/Jul/07 06:16 PM
Attachment Matcher.java [ 12336050 ]
Paul Elschot made changes - 25/Jul/07 06:16 PM
Attachment Scorer-20060628.patch [ 12336047 ]
Paul Elschot made changes - 25/Jul/07 06:16 PM
Attachment Searchable-20060628.patch [ 12336045 ]
Paul Elschot made changes - 25/Jul/07 06:16 PM
Attachment Searcher-20060628.patch [ 12336046 ]
Paul Elschot made changes - 25/Jul/07 06:16 PM
Attachment SortedVIntList.java [ 12344133 ]
Paul Elschot made changes - 25/Jul/07 06:16 PM
Attachment TestSortedVIntList.java [ 12336095 ]
Paul Elschot made changes - 30/Jul/07 07:15 PM
Attachment Matcher2-default-20070730.patch [ 12362793 ]
Attachment Matcher1-ground-20070730.patch [ 12362792 ]
Attachment Matcher3-core-20070730.patch [ 12362794 ]
Paul Elschot made changes - 30/Jul/07 07:16 PM
Attachment Matcher-core20070725.patch [ 12362546 ]
Paul Elschot made changes - 30/Jul/07 07:16 PM
Attachment Matcher-default20070725.patch [ 12362545 ]
Paul Elschot made changes - 30/Jul/07 07:17 PM
Attachment Matcher-ground20070725.patch [ 12362544 ]
Paul Elschot made changes - 30/Jul/07 07:24 PM
Attachment Matcher5-contrib-queries-20070730.patch [ 12362796 ]
Attachment Matcher6-contrib-xml-20070730.patch [ 12362797 ]
Attachment Matcher4-contrib-misc-20070730.patch [ 12362795 ]
Paul Elschot made changes - 30/Jul/07 07:27 PM
Attachment Matcher3-core-20070730.patch [ 12362800 ]
Attachment Matcher2-default-20070730.patch [ 12362799 ]
Attachment Matcher1-ground-20070730.patch [ 12362798 ]
Paul Elschot made changes - 30/Jul/07 07:28 PM
Attachment Matcher6-contrib-xml-20070730.patch [ 12362803 ]
Attachment Matcher4-contrib-misc-20070730.patch [ 12362801 ]
Attachment Matcher5-contrib-queries-20070730.patch [ 12362802 ]
Paul Elschot made changes - 30/Jul/07 07:28 PM
Attachment Matcher1-ground-20070730.patch [ 12362792 ]
Paul Elschot made changes - 30/Jul/07 07:28 PM
Attachment Matcher2-default-20070730.patch [ 12362793 ]
Paul Elschot made changes - 30/Jul/07 07:28 PM
Attachment Matcher3-core-20070730.patch [ 12362794 ]
Paul Elschot made changes - 30/Jul/07 07:28 PM
Attachment Matcher4-contrib-misc-20070730.patch [ 12362795 ]
Paul Elschot made changes - 30/Jul/07 07:28 PM
Attachment Matcher5-contrib-queries-20070730.patch [ 12362796 ]
Paul Elschot made changes - 30/Jul/07 07:29 PM
Attachment Matcher6-contrib-xml-20070730.patch [ 12362797 ]
Paul Elschot made changes - 05/Sep/07 09:27 PM
Attachment Matcher-20070905-3core.patch [ 12365213 ]
Attachment Matcher-20070905-2default.patch [ 12365212 ]
Attachment Matcher-20070905-1ground.patch [ 12365211 ]
Paul Elschot made changes - 18/Sep/07 03:27 PM
Attachment Matcher1-ground-20070730.patch [ 12362798 ]
Paul Elschot made changes - 18/Sep/07 03:27 PM
Attachment Matcher2-default-20070730.patch [ 12362799 ]
Paul Elschot made changes - 18/Sep/07 03:28 PM
Attachment Matcher3-core-20070730.patch [ 12362800 ]
Paul Elschot made changes - 18/Sep/07 03:28 PM
Attachment Matcher4-contrib-misc-20070730.patch [ 12362801 ]
Paul Elschot made changes - 18/Sep/07 03:28 PM
Attachment Matcher5-contrib-queries-20070730.patch [ 12362802 ]
Paul Elschot made changes - 18/Sep/07 03:28 PM
Attachment Matcher6-contrib-xml-20070730.patch [ 12362803 ]
Paul Elschot made changes - 08/Oct/07 06:13 PM
Attachment Matcher-20071008-1ground.patch [ 12367277 ]
Paul Elschot made changes - 08/Oct/07 06:13 PM
Attachment Matcher-20071008-1ground.patch [ 12367277 ]
Paul Elschot made changes - 08/Oct/07 06:15 PM
Attachment Matcher-20071008-1ground.patch [ 12367278 ]
Paul Elschot made changes - 22/Nov/07 06:31 PM
Attachment Matcher-20071122-1ground.patch [ 12370083 ]
Paul Elschot made changes - 22/Nov/07 06:31 PM
Attachment Matcher-20071122-1ground.patch [ 12370083 ]
Paul Elschot made changes - 22/Nov/07 06:32 PM
Attachment Matcher-20070905-1ground.patch [ 12365211 ]
Paul Elschot made changes - 22/Nov/07 06:33 PM
Attachment Matcher-20071122-1ground.patch [ 12370084 ]
Paul Elschot made changes - 22/Nov/07 06:34 PM
Attachment Matcher-20071008-1ground.patch [ 12367278 ]
Michael Busch made changes - 28/Nov/07 09:15 AM
Assignee Michael Busch [ michaelbusch ]
Michael Busch made changes - 28/Nov/07 09:25 AM
Attachment lucene-584.patch [ 12370398 ]
Michael Busch made changes - 03/Dec/07 05:53 AM
Attachment lucene-584-take2.patch [ 12370809 ]
Michael Busch made changes - 06/Dec/07 05:39 PM
Fix Version/s 2.4 [ 12312681 ]
Michael Busch made changes - 10/Jan/08 08:04 AM
Attachment lucene-584-take3-part2.patch [ 12372887 ]
Attachment lucene-584-take3-part1.patch [ 12372886 ]
Michael Busch made changes - 11/Jan/08 08:58 AM
Attachment lucene-584-take4-part2.patch [ 12372965 ]
Attachment lucene-584-take4-part1.patch [ 12372964 ]
Paul Elschot made changes - 11/Jan/08 02:06 PM
Attachment ContribQueries20080111.patch [ 12372978 ]
Paul Elschot made changes - 11/Jan/08 08:47 PM
Attachment Test20080111.patch [ 12373007 ]
Paul Elschot made changes - 11/Jan/08 08:47 PM
Attachment Test20080111.patch [ 12373007 ]
Paul Elschot made changes - 11/Jan/08 08:48 PM
Attachment Test20080111.patch [ 12373008 ]
Michael Busch made changes - 01/Feb/08 03:54 AM
Attachment lucene-584-take5-part2.patch [ 12374525 ]
Attachment lucene-584-take5-part1.patch [ 12374524 ]
Michael Busch made changes - 02/Feb/08 07:16 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Paul Elschot made changes - 03/Feb/08 08:57 AM
Attachment CHANGES.txt.patch [ 12374632 ]
Michael McCandless made changes - 11/Oct/08 12:49 PM
Status Resolved [ 5 ] Closed [ 6 ]
Mark Miller made changes - 21/Aug/09 01:27 AM
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Michael Busch made changes - 21/Aug/09 07:34 AM
Fix Version/s 2.4 [ 12312681 ]
Fix Version/s 2.9 [ 12312682 ]
Mark Miller made changes - 21/Aug/09 03:29 PM
Assignee Michael Busch [ michaelbusch ] Mark Miller [ markrmiller@gmail.com ]
Mark Miller made changes - 22/Aug/09 09:18 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Mark Miller made changes - 25/Sep/09 04:23 PM
Status Resolved [ 5 ] Closed [ 6 ]