[#LUCENE-510] IndexOutput.writeString() should write length in bytes

Lucene - Java

IndexOutput.writeString() should write length in bytes

Created: 03/Mar/06 03:30 AM Updated: 11/Oct/08 12:49 PM

Return to search

Component/s:

Store

Affects Version/s:

2.1

Fix Version/s:

2.4

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
LUCENE-510.patch	2008-03-04 08:55 PM	Michael McCandless	51 kB
LUCENE-510.take2.patch	2008-03-17 08:04 PM	Michael McCandless	120 kB
SortExternal.java	2006-06-05 08:54 AM	Marvin Humphrey	15 kB
strings.diff	2006-05-09 04:04 AM	Marvin Humphrey	27 kB
TestSortExternal.java	2006-06-05 08:54 AM	Marvin Humphrey	6 kB

Issue Links:

Reference

This issue relates to:

~~LUCENE-509~~ Performance optimization when retrieving a single field from a document

This issue is related to:

~~HADOOP-302~~ class Text (replacement for class UTF8) was: HADOOP-136

Resolution Date:

09/May/08 12:05 PM

Description

« Hide

We should change the format of strings written to indexes so that the length of the string is in bytes, not Java characters. This issue has been discussed at:

http://www.mail-archive.com/java-dev@lucene.apache.org/msg01970.html

We must increment the file format number to indicate this change. At least the format number in the segments file should change.

I'm targetting this for 2.1, i.e., we shouldn't commit it to trunk until after 2.0 is released, to minimize incompatible changes between 1.9 and 2.0 (other than removal of deprecated features).

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Doug Cutting made changes - 03/Mar/06 03:32 AM

Field	Original Value	New Value
Link		This issue relates to ~~LUCENE-509~~ [ ~~LUCENE-509~~ ]

Marvin Humphrey made changes - 09/May/06 04:04 AM

Attachment

strings.diff [ 12326413 ]

Marvin Humphrey made changes - 05/Jun/06 08:54 AM

Attachment		SortExternal.java [ 12335016 ]
Attachment		TestSortExternal.java [ 12335017 ]

Doug Cutting made changes - 08/Jul/06 03:03 PM

Link

This issue is related to ~~HADOOP-302~~ [ ~~HADOOP-302~~ ]

Grant Ingersoll made changes - 04/Jan/07 02:06 AM

Assignee

Grant Ingersoll [ gsingers ]

Grant Ingersoll made changes - 04/Jan/07 02:06 AM

Status

Open [ 1 ]

In Progress [ 3 ]

Michael McCandless made changes - 27/Feb/07 04:55 PM

Fix Version/s		2.2 [ 12312328 ]
Fix Version/s	2.1 [ 12310854 ]

Grant Ingersoll made changes - 01/Jun/07 05:07 PM

Fix Version/s

2.2 [ 12312328 ]

Grant Ingersoll made changes - 01/Jun/07 05:07 PM

Status

In Progress [ 3 ]

Open [ 1 ]

Grant Ingersoll made changes - 01/Jun/07 05:07 PM

Assignee

Grant Ingersoll [ gsingers ]

Michael McCandless made changes - 11/Jan/08 10:03 AM

Assignee

Michael McCandless [ mikemccand ]

Michael McCandless made changes - 04/Mar/08 08:55 PM

Attachment

LUCENE-510.patch [ 12377123 ]

Michael McCandless made changes - 17/Mar/08 08:04 PM

Attachment

LUCENE-510.take2.patch [ 12378068 ]

Michael McCandless made changes - 26/Mar/08 01:38 PM

Resolution		Fixed [ 1 ]
Fix Version/s		2.4 [ 12312681 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Michael McCandless made changes - 09/May/08 10:00 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Michael McCandless made changes - 09/May/08 12:05 PM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Resolved [ 5 ]

Michael McCandless made changes - 11/Oct/08 12:49 PM

Status

Resolved [ 5 ]

Closed [ 6 ]