[#LUCENE-1367] Add a isDeleted method to IndexCommit

Lucene - Java

Add a isDeleted method to IndexCommit

Created: 28/Aug/08 11:06 AM Updated: 11/Oct/08 12:49 PM

Return to search

Component/s:

Index

Affects Version/s:

2.4

Fix Version/s:

2.4

Time Tracking:

Not Specified

Lucene Fields:	New
Resolution Date:	28/Aug/08 11:54 AM

Description

« Hide

I wish to add a IndexCommit.isDeleted() method.

The use-case is that Solr will now support configurable IndexDeletionPolicy (~~SOLR-617~~). For the new replication (~~SOLR-561~~) to work, we need access to a list of IndexCommit instances which haven't been deleted yet. I can wrap the user specified IndexDeletionPolicy but since the IndexCommit does not have a isDeleted method, I may store a reference to an IndexCommit on which delete() has been called by the deletion policy. I can wrap the IndexCommit objects too just for having a isDeleted() method so a workaround exists. Not a big pain but if it can be managed on the lucene side easily, I'll appreciate it. It would save me from writing some delegate code.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael McCandless added a comment - 28/Aug/08 11:36 AM

Makes sense, this is simple. I'll commit shortly.

Michael McCandless made changes - 28/Aug/08 11:36 AM

Field	Original Value	New Value
Assignee		Michael McCandless [ mikemccand ]

[ Permlink | « Hide ]

Shalin Shekhar Mangar added a comment - 28/Aug/08 11:39 AM

Thanks Michael!

Repository	Revision	Date	User	Message
ASF	#689791	Thu Aug 28 11:50:15 UTC 2008	mikemccand	~~LUCENE-1367~~: add IndexCommit.isDeleted()
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SnapshotDeletionPolicy.java MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestDeletionPolicy.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexCommit.java MODIFY /lucene/java/trunk/CHANGES.txt MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexFileDeleter.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DirectoryIndexReader.java

[ Permlink | « Hide ]

Michael McCandless added a comment - 28/Aug/08 11:53 AM

Thank you Shalin!

Michael McCandless made changes - 28/Aug/08 11:54 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Michael McCandless made changes - 11/Oct/08 12:49 PM

Status

Resolved [ 5 ]

Closed [ 6 ]