Issue Details (XML | Word | Printable)

Key: LUCENE-1366
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Michael McCandless
Reporter: Michael McCandless
Votes: 2
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Lucene - Java

Rename Field.Index.UN_TOKENIZED/TOKENIZED/NO_NORMS

Created: 28/Aug/08 10:07 AM   Updated: 11/Oct/08 12:49 PM
Return to search
Component/s: None
Affects Version/s: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2
Fix Version/s: 2.4

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works LUCENE-1366.patch 2008-09-07 06:51 PM Michael McCandless 226 kB
Text File Licensed for inclusion in ASF works LUCENE-1366.patch 2008-08-28 01:45 PM Michael McCandless 4 kB

Lucene Fields: New
Resolution Date: 10/Sep/08 09:39 PM


 Description  « Hide
There is confusion about these current Field options and I think we
should rename them, deprecating the old names in 2.4/2.9 and removing
them in 3.0. How about this:
TOKENIZED --> ANALYZED
UN_TOKENIZED --> NOT_ANALYZED
NO_NORMS --> NOT_ANALYZED_NO_NORMS

Should we also add ANALYZED_NO_NORMS?

Spinoff from here:

http://mail-archives.apache.org/mod_mbox/lucene-java-user/200808.mbox/%3C48a3076a.2679420a.1c53.ffffa5c4%40mx.google.com%3E



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Michael McCandless added a comment - 28/Aug/08 01:45 PM
Initial patch attached.

I intend also fix all places where we use the now-deprecated older names to use the new names on the next rev of this patch, but wanted to get the basic change out first in case anyone has violent reactions to the new proposed names Naming is always the hardest part!


Otis Gospodnetic added a comment - 28/Aug/08 05:18 PM
I like the name choices - they read nicely, are easy to understand, and match what actually happens.

Michael McCandless added a comment - 07/Sep/08 06:51 PM
OK, this patch switches over all uses of the old names to the new ones.

I plan to commit in a day or two.


Michael McCandless added a comment - 10/Sep/08 09:39 PM
Committed revision 694004.