|
If you were logged in you would be able to see more operations.
|
|
|
| Lucene Fields: |
Patch Available, New
|
| Resolution Date: |
03/Sep/08 11:19 PM
|
|
TopDocCollector's members and constructor are declared either private or package visible. It makes it hard to extend it as if you want to extend it you can reuse its hq and totatlHits members, but need to define your own. It also forces you to override getTotalHits() and topDocs().
By changing its members and constructor (the one that accepts a PQ) to protected, we allow users to extend it in order to get a different view of 'top docs' (like TopFieldCollector does), but still enjoy its getTotalHits() and topDocs() method implementations.
|
|
Description
|
TopDocCollector's members and constructor are declared either private or package visible. It makes it hard to extend it as if you want to extend it you can reuse its hq and totatlHits members, but need to define your own. It also forces you to override getTotalHits() and topDocs().
By changing its members and constructor (the one that accepts a PQ) to protected, we allow users to extend it in order to get a different view of 'top docs' (like TopFieldCollector does), but still enjoy its getTotalHits() and topDocs() method implementations. |
Show » |
made changes - 13/Aug/08 02:00 PM
| Field |
Original Value |
New Value |
|
Attachment
|
|
1356.patch
[ 12388144
]
|
made changes - 13/Aug/08 02:14 PM
|
Assignee
|
|
Doron Cohen
[ doronc
]
|
made changes - 18/Aug/08 08:09 AM
|
Attachment
|
|
1356-2.patch
[ 12388411
]
|
made changes - 18/Aug/08 08:09 AM
|
Fix Version/s
|
|
2.3.3
[ 12313327
]
|
|
Lucene Fields
|
[Patch Available, New]
|
[New, Patch Available]
|
made changes - 19/Aug/08 01:12 PM
|
Fix Version/s
|
|
2.4
[ 12312681
]
|
made changes - 03/Sep/08 11:19 PM
|
Resolution
|
|
Fixed
[ 1
]
|
|
Lucene Fields
|
[Patch Available, New]
|
[New, Patch Available]
|
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Improvement
Closed
Minor
Allow easy extensions of TopDocCollector
