Issue Details (XML | Word | Printable)

Key: LUCENE-1354
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Grant Ingersoll
Reporter: Grant Ingersoll
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Lucene - Java

Provide Programmatic Access to CheckIndex

Created: 11/Aug/08 07:44 PM   Updated: 11/Oct/08 12:49 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works LUCENE-1354.patch 2008-09-09 04:31 PM Grant Ingersoll 20 kB
Text File Licensed for inclusion in ASF works LUCENE-1354.patch 2008-09-07 10:52 AM Michael McCandless 18 kB
Text File Licensed for inclusion in ASF works LUCENE-1354.patch 2008-08-11 07:50 PM Grant Ingersoll 18 kB
Issue Links:
Blocker
 

Lucene Fields: New
Resolution Date: 12/Sep/08 09:44 AM


 Description  « Hide
Would be nice to have programmatic access to the CheckIndex tool, so that it can be used in applications like Solr.

See SOLR-566



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Grant Ingersoll added a comment - 11/Aug/08 07:50 PM
Here's some incomplete doodling on this issue. Haven't had time to finish it off, but thought I'd get it out of my source tree for now and come back to it later.

Michael McCandless added a comment - 07/Sep/08 10:52 AM
Hi Grant, the patch looks good! I tweaked it a bit, to pass all tests, and also pulled out a separate fix() method as suggested here:

http://mail-archives.apache.org/mod_mbox/lucene-java-dev/200809.mbox/%3C4d0b24970809061944n5c617b36xc2951d74d989dc42%40mail.gmail.com%3E

If this looks good can you commit for 2.4?


Grant Ingersoll added a comment - 07/Sep/08 12:06 PM

Grant Ingersoll added a comment - 09/Sep/08 04:03 PM - edited
Mike, I think you forgot to add the CheckIndexStatus class to your patch. However, I reproduced it from an old version here, plus your additions.

Grant Ingersoll added a comment - 09/Sep/08 04:31 PM
Has CheckIndexStatus. Will commit shortly

Michael McCandless added a comment - 11/Sep/08 08:13 PM

Mike, I think you forgot to add the CheckIndexStatus class to your patch. However, I reproduced it from an old version here, plus your additions.

Woops, sorry. We really need the "svn patch" command, so that it would have locally added that file on me applying the patch. Sigh. But you worked around this just fine


Michael McCandless added a comment - 12/Sep/08 09:44 AM
Grant, this is now fixed right?