[#LUCENE-1334] Term improvement

Lucene - Java

Term improvement

Created: 11/Jul/08 05:25 PM Updated: 11/Oct/08 12:49 PM

Return to search

Component/s:

Index

Affects Version/s:

2.3.1

Fix Version/s:

2.4

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	LUCENE-1334.txt	2008-07-11 08:43 PM	DM Smith	13 kB

Environment:

all

Lucene Fields:	New
Resolution Date:	19/Aug/08 10:40 AM

Description

« Hide

Term is designed for reuse of the supplied filter, to minimize intern().

One of the common use patterns is to create a Term with the txt field being an empty string.

To simplify this pattern and to document it's usefulness, I suggest adding a constructor:
public Term(String fld)
with the obvious implementation
and use it throughout core and contrib as a replacement.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

DM Smith added a comment - 11/Jul/08 08:43 PM

patch for the issue

DM Smith made changes - 11/Jul/08 08:43 PM

Field	Original Value	New Value
Attachment		LUCENE-1334.txt [ 12385901 ]

Michael McCandless made changes - 19/Aug/08 10:10 AM

Assignee

Michael McCandless [ mikemccand ]

[ Permlink | « Hide ]

Michael McCandless added a comment - 19/Aug/08 10:36 AM

Patch looks good, thanks DM! I'll commit shortly.

Repository	Revision	Date	User	Message
ASF	#687014	Tue Aug 19 10:40:39 UTC 2008	mikemccand	~~LUCENE-1334~~: add Term(String fieldName) constructor that sets term text to empty string
				Files Changed
				MODIFY /lucene/java/trunk/contrib/queries/src/java/org/apache/lucene/search/FuzzyLikeThisQuery.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java MODIFY /lucene/java/trunk/contrib/spellchecker/src/java/org/apache/lucene/search/spell/LuceneDictionary.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/RangeFilter.java MODIFY /lucene/java/trunk/contrib/queries/src/java/org/apache/lucene/search/DuplicateFilter.java MODIFY /lucene/java/trunk/contrib/memory/src/java/org/apache/lucene/index/memory/MemoryIndex.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/ExtendedFieldCacheImpl.java MODIFY /lucene/java/trunk/contrib/miscellaneous/src/java/org/apache/lucene/index/FieldNormModifier.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/Term.java MODIFY /lucene/java/trunk/contrib/analyzers/src/java/org/apache/lucene/analysis/query/QueryAutoStopWordAnalyzer.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/ParallelReader.java MODIFY /lucene/java/trunk/CHANGES.txt MODIFY /lucene/java/trunk/contrib/miscellaneous/src/java/org/apache/lucene/misc/LengthNormModifier.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/RangeQuery.java

[ Permlink | « Hide ]

Michael McCandless added a comment - 19/Aug/08 10:40 AM

Thanks DM!

Michael McCandless made changes - 19/Aug/08 10:40 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Michael McCandless made changes - 11/Oct/08 12:49 PM

Status

Resolved [ 5 ]

Closed [ 6 ]