Issue Details (XML | Word | Printable)

Key: LUCENE-1295
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Grant Ingersoll
Reporter: Grant Ingersoll
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Lucene - Java

Make retrieveTerms(int docNum) public in MoreLikeThis

Created: 28/May/08 06:25 PM   Updated: 02/Jun/08 12:29 PM
Return to search
Component/s: contrib/*
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works LUCENE-1295.patch 2008-05-28 06:28 PM Grant Ingersoll 2 kB

Lucene Fields: New
Resolution Date: 02/Jun/08 12:29 PM


 Description  « Hide
It would be useful if
private PriorityQueue retrieveTerms(int docNum) throws IOException {

were public, since it is similar in use to

public PriorityQueue retrieveTerms(Reader r) throws IOException {

It also seems useful to add

public String [] retrieveInterestingTerms(int docNum) throws IOException{

to mirror the one that works on Reader.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Grant Ingersoll added a comment - 28/May/08 06:28 PM
I'll commit in a day or two.

Otis Gospodnetic added a comment - 29/May/08 05:02 AM
Perque no. I see MLT is full of tabs, should you feel like fixing the formating.

Grant Ingersoll added a comment - 29/May/08 02:31 PM

Perque no.

Huh?

I see MLT is full of tabs, should you feel like fixing the formating.

Yeah, I noticed that too, and it is quite egregious, but I thought we avoided formatting changes, but I am happy to make an exception here.


Otis Gospodnetic added a comment - 31/May/08 04:26 AM
I think cosmetic changes are OK if:
  • they are not mixed with functional changes
  • there are no patches for the cleaned-up class(es) in JIRA

In this case I see only a couple of MLT issues, all of which look like we can take care of them quickly, and then somebody can clean up a little if we feel like it. Anyhow...


Grant Ingersoll added a comment - 02/Jun/08 12:29 PM
Committed revision 662413.