Issue Details (XML | Word | Printable)

Key: LUCENE-1290
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Michael Busch
Reporter: Michael Busch
Votes: 2
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Lucene - Java

Deprecate Hits

Created: 19/May/08 09:03 PM   Updated: 11/Oct/08 12:49 PM
Return to search
Component/s: Search
Affects Version/s: None
Fix Version/s: 2.4

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works lucene-1290.patch 2008-05-23 06:55 PM Michael Busch 236 kB
Text File Licensed for inclusion in ASF works lucene-1290.patch 2008-05-20 08:23 AM Michael Busch 218 kB
Text File Licensed for inclusion in ASF works lucene-1290.patch 2008-05-19 09:04 PM Michael Busch 214 kB

Lucene Fields: Patch Available, New
Resolution Date: 23/May/08 07:00 PM


 Description  « Hide
The Hits class has several drawbacks as pointed out in LUCENE-954.
The other search APIs that use TopDocCollector and TopDocs should be used instead.

This patch:

  • deprecates org/apache/lucene/search/Hits, Hit, and HitIterator, as well as
    the Searcher.search( * ) methods which return a Hits Object.
  • removes all references to Hits from the core and uses TopDocs and ScoreDoc
    instead
  • Changes the demo SearchFiles: adds the two modes 'paging search' and 'streaming search',
    each of which demonstrating a different way of using the search APIs. The former
    uses TopDocs and a TopDocCollector, the latter a custom HitCollector implementation.
  • Updates the online tutorial that descibes the demo.

All tests pass.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #659626 Fri May 23 18:57:55 UTC 2008 buschmi LUCENE-1290: Deprecate org.apache.lucene.search.Hits, Hit and HitIterator.
Files Changed
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestMultiPhraseQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestDeletionPolicy.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestPositionIncrement.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestTermVectors.java
MODIFY /lucene/java/trunk/docs/scoring.pdf
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestBoolean2.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/document/TestDocument.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/store/TestLockFactory.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestLazyProxSkipping.java
MODIFY /lucene/java/trunk/docs/demo2.html
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestRangeFilter.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestFilteredSearch.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestNot.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestMatchAllDocsQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestMultiSearcher.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/function/TestFieldScoreQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestBooleanMinShouldMatch.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestBooleanScorer.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReader.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestRangeQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestMultiSearcherRanking.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestConstantScoreRangeQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestCustomSearcherSort.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/Hit.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestFuzzyQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestParallelReader.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestFilteredQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/store/TestBufferedIndexInput.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestWildcard.java
MODIFY /lucene/java/trunk/src/demo/org/apache/lucene/demo/SearchFiles.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestBooleanOr.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/queryParser/TestQueryParser.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestBackwardsCompatibility.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestRemoteCachingWrapperFilter.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/analysis/TestKeywordAnalyzer.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestPhrasePrefixQuery.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/function/TestOrdValues.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriterDelete.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestDateFilter.java
MODIFY /lucene/java/trunk/src/site/src/documentation/content/xdocs/scoring.xml
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestSearchHitsWithDeletions.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestTimeLimitedCollector.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/SearchTestForDuplicates.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/TestSearchForDuplicates.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestPhraseQuery.java
MODIFY /lucene/java/trunk/CHANGES.txt
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/TestDemo.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/TestHitIterator.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/ThreadSafetyTest.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/queryParser/TestMultiFieldQueryParser.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/HitIterator.java
MODIFY /lucene/java/trunk/docs/demo2.pdf
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestDateSort.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestPrefixFilter.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderReopen.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestRemoteSearchable.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/document/Document.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/CheckHits.java
MODIFY /lucene/java/trunk/src/site/src/documentation/content/xdocs/demo2.xml
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestPrefixQuery.java
MODIFY /lucene/java/trunk/docs/scoring.html
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/SearchTest.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/TestSearch.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestSort.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/search/Hits.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java