[#LUCENE-1288] Add getVersion method to IndexCommit

Lucene - Java

Add getVersion method to IndexCommit

Created: 19/May/08 02:04 PM Updated: 11/Oct/08 12:49 PM

Return to search

Component/s:

None

Affects Version/s:

2.3.1

Fix Version/s:

2.4

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	LUCENE-1288.patch	2008-05-23 09:39 AM	Michael McCandless	6 kB

Lucene Fields:	New
Resolution Date:	28/May/08 11:01 AM

Description

« Hide

Returns the equivalent of IndexReader.getVersion for IndexCommit

public abstract long getVersion();

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Michael McCandless made changes - 19/May/08 07:32 PM

Field	Original Value	New Value
Assignee		Michael McCandless [ mikemccand ]

[ Permlink | « Hide ]

Jason Rutherglen added a comment - 20/May/08 12:03 AM

Probably best to add getGeneration method

[ Permlink | « Hide ]

Michael McCandless added a comment - 20/May/08 08:53 AM

Are you suggesting instead or in addition to getVersion?

[ Permlink | « Hide ]

Jason Rutherglen added a comment - 20/May/08 11:51 AM

getGeneration in addition.

Will IndexCommit.getVersion return the same value as the IndexReader that created it? I'm using this in conjunction with IndexReader to close an object associated with the IndexReader upon deletion of the snapshot.

[ Permlink | « Hide ]

Michael McCandless added a comment - 20/May/08 12:01 PM

OK I'll do both. Yes, getVersion() will be the same as IndexReader.getVersion() if that reader was opened on the same commit point.

[ Permlink | « Hide ]

Michael McCandless added a comment - 23/May/08 09:39 AM

Attached patch. I plan to commit in a day or two.

Michael McCandless made changes - 23/May/08 09:39 AM

Attachment

LUCENE-1288.patch [ 12382629 ]

Repository	Revision	Date	User	Message
ASF	#660904	Wed May 28 11:00:33 UTC 2008	mikemccand	~~LUCENE-1288~~: add getVersion, getGeneration to IndexCommit
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SnapshotDeletionPolicy.java MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestDeletionPolicy.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexCommit.java MODIFY /lucene/java/trunk/CHANGES.txt MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexFileDeleter.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DirectoryIndexReader.java

Michael McCandless made changes - 28/May/08 11:01 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		2.4 [ 12312681 ]

Michael McCandless made changes - 11/Oct/08 12:49 PM

Status

Resolved [ 5 ]

Closed [ 6 ]