add numDocs() and maxDoc() methods to IndexWriter; deprecate docCount()

• Key: LUCENE-1267
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Michael McCandless
• Reporter: Michael McCandless
• Component/s: Index
• Affects Version/s: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1
• Fix Version/s: 2.4

Description

Spinoff from here:

http://mail-archives.apache.org/mod_mbox/lucene-java-user/200804.mbox/[e-mail]%3e

I think we should add maxDoc() and numDocs() methods to IndexWriter,
and deprecate docCount() in favor of maxDoc(). To do this I think we
should cache the deletion count of each segment in the segments file.

Comments

Attached patch.

This changes the segments file to store the deletion count per
segment. I added package-private get/setDelCount to SegmentInfo. I
also added BitVector.getAndSet, which sets the bit but returns the
starting value of that bit. I use this to only increment deletion
count if the doc wasn't already deleted.

I plan to commit in a day or two.