|
[
Permlink
| « Hide
]
Steven Rowe added a comment - 01/Apr/08 12:04 AM
Patch implementing above-described changes.
The issue that introduced generation of Changes.html
Since the Lucene Bugzilla bugs mentioned in CHANGES.txt are no longer present in the Apache Bugzilla database, it doesn't make sense to auto-linkify these any longer.
Instead, this version of the patch links from each mentioned Bugzilla bug number to the JIRA issue that was cloned from it, and includes the JIRA issue name. For example, the following text:
becomes:
I didn't try it but from the description it sounds great.
I'll try it over the weekend. For the fancy stylesheet - I put those colors but no sentiments for them here - please feel free to modify them to your taste..  One last bugfix: item #3.1 under 2.3.0's "New features" section is intended to be understood as a component of item #3. This version of the patch renumbers this item to #4, like all previous versions, but it no longer includes a '1' at the beginning of the item's text, as all previous versions did.
Should hierarchical change item formatting be supported? AFAICT, the above-described item #3.1 is the only occurrence of this phenomenon currently in CHANGES.txt. One last feature: added "Expand All" and "Collapse All" buttons at the top of the page.
These buttons are added via Javascript, so they don't appear when Javascript disabled and everything is always expanded. This version also cleans up some mis-identified change attributions, e.g. "(see #3 above)". Patch looks great!
One minor issue the dynamically inserted buttons do not work on IE 6 for me. I changed that to create them in the static HTML lines and now it works in both IE and FF. Also modified the colors of the fancy style to be more pleasant and made it default again - for visible separation between the three parts (trunk, last release, older releases). Attaching the update - will commit soon. Doron Hi Doron, I like the Fancy stylesheet now - thanks. Attaching a new patch that contains a couple of small changes from your version:
I just realized that adding the buttons statically means they are shown also when javascript is disabled and then they do nothing.
I would like to have both - buttons that work also in IE6 and view that is consistent also with javascript disabled. If this is not possible I think it is more important for IE6 to work properly. Steven? I just realized that I didn't save the editor buffer where I removed the extra styles from ChangesFixedWidthStyle.css – somehow, there are three copies of each style in there. Not attaching (yet another) patch - can you manually remove the extras, Doron?
Actually there are now 3 duplicates in ChangesFixedWidthStyle.css - never mind I'll remove that.
Yes now without the setAttribute() it works for me too in IE6 as well. So I am committing this. Second time in a row(e)
that I am too slow for your fast response... One tiny display issue I noticed: the Bugzilla issue autolinkification places the </a> tag before the closing right square bracket (']') around the LUCENE-XXXX issue, so the closing bracket is not part of the link text, but it should be.
This occurs on line #389 on changes2html.pl: . qq!$issue [LUCENE-$jira_issue_num</a>]! should be . qq!$issue [LUCENE-$jira_issue_num]</a>! Again, not including another patch - would you mind fixing this for me, Doron? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Improvement
Closed
Trivial
Changes.html formatting improvements
