[#LUCENE-1228] IndexWriter.commit() does not update the index version

Lucene - Java

IndexWriter.commit() does not update the index version

Created: 13/Mar/08 07:19 PM Updated: 14/Mar/08 11:49 PM

Return to search

Component/s:

Index

Affects Version/s:

2.4

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	lucene-1228-commit-reopen.patch	2008-03-13 07:24 PM	Doron Cohen	5 kB

Issue Links:

Reference

This issue is related to:

~~LUCENE-1232~~ Use segments generation instead of version

Lucene Fields:	Patch Available
Resolution Date:	14/Mar/08 10:35 AM

Description

« Hide

IndexWriter.commit() can update the index version and generation but the update of version is lost.
As result added documents are not seen by IndexReader.reopen().
(There might be other side effects that I am not aware of).
The fix is 1 line - update also the version in SegmentsInfo.updateGeneration().
(Finding this line involved more lines though...

)

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Doron Cohen added a comment - 13/Mar/08 07:24 PM

Patch with a fix + a test that demonstrates the bug.
All core tests pass. Will run all tests later on.

Doron Cohen made changes - 13/Mar/08 07:24 PM

Field	Original Value	New Value
Attachment		lucene-1228-commit-reopen.patch [ 12377824 ]

[ Permlink | « Hide ]

Michael McCandless added a comment - 13/Mar/08 08:07 PM

Good catch Doron, thanks!

This only affects trunk (2.4).

[ Permlink | « Hide ]

Doron Cohen added a comment - 13/Mar/08 08:15 PM

Oh good, less migration to do.
Mmm.. so it is not related to Daniel's "Document ID shuffling under 2.3.x" in the user list.

Doron Cohen made changes - 13/Mar/08 08:16 PM

Affects Version/s	2.3 [ 12312531 ]
Lucene Fields	[Patch Available, New]	[New, Patch Available]
Affects Version/s	2.3.1 [ 12312975 ]

[ Permlink | « Hide ]

Ning Li added a comment - 13/Mar/08 10:30 PM

Does SegmentInfos really need both "version" and "generation"? Is "generation" sufficient?

[ Permlink | « Hide ]

Michael McCandless added a comment - 14/Mar/08 08:30 AM

Does SegmentInfos really need both "version" and "generation"? Is "generation" sufficient?

I believe they are in fact redundant. I tested this with a small change to just return generation when getVersion is called and all tests pass. I'll open a new issue.

[ Permlink | « Hide ]

Doron Cohen added a comment - 14/Mar/08 10:35 AM

Committed.

Doron Cohen made changes - 14/Mar/08 10:35 AM

Resolution		Fixed [ 1 ]
Lucene Fields	[Patch Available, New]	[Patch Available]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#637041	Fri Mar 14 10:35:18 UTC 2008	doronc	~~LUCENE-1228~~: IndexWriter.commit() was not updating the index version.
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SegmentInfos.java MODIFY /lucene/java/trunk/CHANGES.txt MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderReopen.java

Hoss Man made changes - 14/Mar/08 11:49 PM

Link

This issue is related to ~~LUCENE-1232~~ [ ~~LUCENE-1232~~ ]