[#LUCENE-1226] IndexWriter.addIndexes(IndexReader[]) fails to create compound files

Lucene - Java

IndexWriter.addIndexes(IndexReader[]) fails to create compound files

Created: 12/Mar/08 09:45 PM Updated: 08/May/08 07:47 PM

Return to search

Component/s:

Index

Affects Version/s:

2.3, 2.3.1

Fix Version/s:

2.3.2, 2.4

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	lucene-1226.patch	2008-03-12 09:46 PM	Michael Busch	0.5 kB

Lucene Fields:	Patch Available, New
Resolution Date:	13/Mar/08 09:03 PM

Description

« Hide

Even if no exception is thrown while writing the compound file at the end of the
addIndexes() call, the transaction is rolled back and the successfully written cfs
file deleted. The fix is simple: There is just the

success = true;

statement missing at the end of the try{} clause.

All tests pass. I'll commit this soon to trunk and 2.3.2.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Michael Busch made changes - 12/Mar/08 09:46 PM

Field	Original Value	New Value
Attachment		lucene-1226.patch [ 12377731 ]

Repository	Revision	Date	User	Message
ASF	#636893	Thu Mar 13 20:57:32 UTC 2008	buschmi	~~LUCENE-1226~~: Fixed IndexWriter.addIndexes(IndexReader[]) to commit successfully created compound files.
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java MODIFY /lucene/java/trunk/CHANGES.txt

Repository	Revision	Date	User	Message
ASF	#636894	Thu Mar 13 21:02:00 UTC 2008	buschmi	~~LUCENE-1226~~: Fixed IndexWriter.addIndexes(IndexReader[]) to commit successfully created compound files.
				Files Changed
				MODIFY /lucene/java/branches/lucene_2_3/src/java/org/apache/lucene/index/IndexWriter.java MODIFY /lucene/java/branches/lucene_2_3/CHANGES.txt

[ Permlink | « Hide ]

Michael Busch added a comment - 13/Mar/08 09:03 PM

Committed to trunk & 2.3 branch.

Michael Busch made changes - 13/Mar/08 09:03 PM

Resolution		Fixed [ 1 ]
Lucene Fields	[Patch Available, New]	[New, Patch Available]
Status	Open [ 1 ]	Resolved [ 5 ]

Michael Busch made changes - 08/May/08 07:47 PM

Status

Resolved [ 5 ]

Closed [ 6 ]