[#LUCENE-1217] use isBinary cached variable instead of instanceof in Field

Lucene - Java

use isBinary cached variable instead of instanceof in Field

Created: 11/Mar/08 09:23 AM Updated: 12/Mar/08 04:57 PM

Return to search

Component/s:

Other

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
Lucene-1217-take1.patch	2008-03-11 09:09 PM	Eks Dev	2 kB
LUCENE-1217.patch	2008-03-11 09:25 AM	Eks Dev	1 kB

Issue Links:

Blocker

This issue blocks:

~~LUCENE-1219~~ support array/offset/ length setters for Field with binary data

Lucene Fields:	Patch Available, New
Resolution Date:	12/Mar/08 10:10 AM

Description

« Hide

Field class can hold three types of values,
See: AbstractField.java protected Object fieldsData = null;

currently, mainly RTTI (instanceof) is used to determine the type of the value stored in particular instance of the Field, but for binary value we have mixed RTTI and cached variable "boolean isBinary"

This patch makes consistent use of cached variable isBinary.

Benefit: consistent usage of method to determine run-time type for binary case (reduces chance to get out of sync on cached variable). It should be slightly faster as well.

Thinking aloud:
Would it not make sense to maintain type with some integer/byte"poor man's enum" (Interface with a couple of constants)
code:java{
public static final interface Type{
public static final byte BOOLEAN = 0;
public static final byte STRING = 1;
public static final byte READER = 2;
....
}
}

and use that instead of isBinary + instanceof?

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Eks Dev made changes - 11/Mar/08 09:25 AM

Field	Original Value	New Value
Attachment		LUCENE-1217.patch [ 12377589 ]

Michael McCandless made changes - 11/Mar/08 01:37 PM

Assignee

Michael McCandless [ mikemccand ]

Eks Dev made changes - 11/Mar/08 09:09 PM

Attachment

Lucene-1217-take1.patch [ 12377639 ]

Eks Dev made changes - 11/Mar/08 09:59 PM

Link

This issue blocks ~~LUCENE-1219~~ [ ~~LUCENE-1219~~ ]

Michael McCandless made changes - 12/Mar/08 10:10 AM

Lucene Fields	[Patch Available, New]	[New, Patch Available]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Doug Cutting made changes - 12/Mar/08 04:57 PM

Description	Filed class can hold three types of values, See: AbstractField.java protected Object fieldsData = null; currently, mainly RTTI (instanceof) is used to determine the type of the value stored in particular instance of the Field, but for binary value we have mixed RTTI and cached variable "boolean isBinary" This patch makes consistent use of cached variable isBinary. Benefit: consistent usage of method to determine run-time type for binary case (reduces chance to get out of sync on cached variable). It should be slightly faster as well. Thinking aloud: Would it not make sense to maintain type with some integer/byte"poor man's enum" (Interface with a couple of constants) code:java{ public static final interface Type{ public static final byte BOOLEAN = 0; public static final byte STRING = 1; public static final byte READER = 2; .... } } and use that instead of isBinary + instanceof?	Field class can hold three types of values, See: AbstractField.java protected Object fieldsData = null; currently, mainly RTTI (instanceof) is used to determine the type of the value stored in particular instance of the Field, but for binary value we have mixed RTTI and cached variable "boolean isBinary" This patch makes consistent use of cached variable isBinary. Benefit: consistent usage of method to determine run-time type for binary case (reduces chance to get out of sync on cached variable). It should be slightly faster as well. Thinking aloud: Would it not make sense to maintain type with some integer/byte"poor man's enum" (Interface with a couple of constants) code:java{ public static final interface Type{ public static final byte BOOLEAN = 0; public static final byte STRING = 1; public static final byte READER = 2; .... } } and use that instead of isBinary + instanceof?
Lucene Fields	[Patch Available, New]	[New, Patch Available]
Summary	use isBinary cached variable instead of instanceof in Filed	use isBinary cached variable instead of instanceof in Field