[#LUCENE-1210] IndexWriter & ConcurrentMergeScheduler deadlock case if starting a merge hits an exception

Lucene - Java

IndexWriter & ConcurrentMergeScheduler deadlock case if starting a merge hits an exception

Created: 09/Mar/08 08:05 AM Updated: 08/May/08 07:47 PM

Return to search

Component/s:

Index

Affects Version/s:

2.3, 2.3.1

Fix Version/s:

2.3.2, 2.4

Time Tracking:

Not Specified

Lucene Fields:	New
Resolution Date:	09/Mar/08 08:18 AM

Description

« Hide

If you're using CMS (the default) and mergeInit hits an exception (eg
OOME), we are not properly clearing IndexWriter's internal tracking of
running merges. This causes IW.close() to hang while it incorrectly
waits for these non-started merges to finish.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael McCandless added a comment - 09/Mar/08 08:06 AM

The fix is trivial: add a try/finally to mergeInit to clear the
internal tracking on exception. I'll commit shortly.

Michael McCandless made changes - 09/Mar/08 08:18 AM

Field	Original Value	New Value
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#635190	Sun Mar 09 08:19:00 UTC 2008	mikemccand	~~LUCENE-1210~~: fix deadlock case on hitting exception in mergeInit
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java

[ Permlink | « Hide ]

Michele Bini added a comment - 10/Mar/08 10:08 AM

Uhm, shouldn't the patch be committed in the 2.3 branch, too, as it affects 2.3.1?

[ Permlink | « Hide ]

Michael McCandless added a comment - 10/Mar/08 10:13 AM

Yes, I agree. At some point soon we should do a 2.3.2 point release, and I'll port this issue back for that.

Repository	Revision	Date	User	Message
ASF	#635912	Tue Mar 11 13:03:54 UTC 2008	mikemccand	~~LUCENE-1210~~ (porting to 2.3): fix deadlock case on hitting an exception while starting a merge when using CMS
				Files Changed
				MODIFY /lucene/java/branches/lucene_2_3/src/java/org/apache/lucene/index/IndexWriter.java MODIFY /lucene/java/branches/lucene_2_3/src/test/org/apache/lucene/index/TestIndexWriter.java MODIFY /lucene/java/branches/lucene_2_3/CHANGES.txt

[ Permlink | « Hide ]

Hoss Man added a comment - 11/Mar/08 07:29 PM

targeted for 2.3.2 bug fix release

Hoss Man made changes - 11/Mar/08 07:29 PM

Fix Version/s

2.3.2 [ 12313057 ]

Michael Busch made changes - 08/May/08 07:47 PM

Status

Resolved [ 5 ]

Closed [ 6 ]