[#LUCENE-1201] Add getIndexCommit method to IndexReader

Lucene - Java

Add getIndexCommit method to IndexReader

Created: 04/Mar/08 12:24 PM Updated: 11/Oct/08 12:49 PM

Return to search

Component/s:

Index

Affects Version/s:

2.1, 2.2, 2.3

Fix Version/s:

2.4

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	LUCENE-1201.patch	2008-03-04 12:27 PM	Michael McCandless	19 kB

Lucene Fields:	New
Resolution Date:	06/Mar/08 12:57 PM

Description

« Hide

Spinoff from this thread:

http://markmail.org/message/bojgqfgyxkkv4fyb

I think it makes sense ask an IndexReader for the commit point it has
open. This enables the use case described in the above thread, which
is to create a deletion policy that is able to query all open readers
for what commit points they are using, and prevent deletion of them.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael McCandless added a comment - 04/Mar/08 12:27 PM

Attached patch. I plan to commit in a day or two.

I also deprecated the original interface IndexCommitPoint, and
switched to abstract base class IndexCommit instead, and added
equals() method to IndexCommit. I also added "warning this API is
still experimental" to the javadocs too.

Michael McCandless made changes - 04/Mar/08 12:27 PM

Field	Original Value	New Value
Attachment		LUCENE-1201.patch [ 12377077 ]

Michael McCandless made changes - 06/Mar/08 12:57 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#634251	Thu Mar 06 12:57:08 UTC 2008	mikemccand	~~LUCENE-1201~~: add IndexReader.getIndexCommit to see which index commit a reader is reading
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SnapshotDeletionPolicy.java MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestDeletionPolicy.java ADD /lucene/java/trunk/src/java/org/apache/lucene/index/IndexCommit.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/KeepOnlyLastCommitDeletionPolicy.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReader.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexDeletionPolicy.java MODIFY /lucene/java/trunk/CHANGES.txt MODIFY /lucene/java/trunk/src/test/org/apache/lucene/TestSnapshotDeletionPolicy.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexFileDeleter.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DirectoryIndexReader.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexCommitPoint.java

Michael McCandless made changes - 11/Oct/08 12:49 PM

Status

Resolved [ 5 ]

Closed [ 6 ]