[#LUCENE-1171] Make DocumentsWriter more robust on hitting OOM

Lucene - Java

Make DocumentsWriter more robust on hitting OOM

Created: 08/Feb/08 09:00 PM Updated: 11/Oct/08 12:49 PM

Return to search

Component/s:

Index

Affects Version/s:

2.3

Fix Version/s:

2.4

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	LUCENE-1171.patch	2008-02-08 09:09 PM	Michael McCandless	13 kB

Lucene Fields:	New
Resolution Date:	11/Feb/08 12:57 PM

Description

« Hide

I've been stress testing DocumentsWriter by indexing wikipedia, but not
giving enough memory to the JVM, in varying heap sizes to tickle the
different interesting cases. Sometimes DocumentsWriter can deadlock;
other times it will hit a subsequent NPE or AIOOBE or assertion
failure.

I've fixed all the cases I've found, and added some more asserts. Now
it just produces plain OOM exceptions. All changes are contained to
DocumentsWriter.java.

All tests pass. I plan to commit in a day or two!

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael McCandless added a comment - 08/Feb/08 09:09 PM

Attached patch.

Michael McCandless made changes - 08/Feb/08 09:09 PM

Field	Original Value	New Value
Attachment		LUCENE-1171.patch [ 12375111 ]

Repository	Revision	Date	User	Message
ASF	#620478	Mon Feb 11 12:55:47 UTC 2008	mikemccand	~~LUCENE-1171~~: better robustness in DocumentsWriter on hitting OOM at various times
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DocumentsWriter.java

Michael McCandless made changes - 11/Feb/08 12:57 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#620756	Tue Feb 12 10:56:19 UTC 2008	mikemccand	~~LUCENE-1171~~ (backport to 2.3): fix cases where DocumentsWriter can deadlock on hitting OOM error
				Files Changed
				MODIFY /lucene/java/branches/lucene_2_3/src/java/org/apache/lucene/index/DocumentsWriter.java MODIFY /lucene/java/branches/lucene_2_3/CHANGES.txt

Michael McCandless made changes - 11/Oct/08 12:49 PM

Status

Resolved [ 5 ]

Closed [ 6 ]