[LOGGING-37] [logging] LogFactory#getLogFactory should not look for method every time

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.4
• Fix Version/s: 1.2

Environment

Operating System: other
Platform: Other

• Bugzilla Id: 38626
• Assignee: Unassigned
• Reporter: Matthias Ernst
• Created: 13/Feb/06 07:23
• Updated: 09/Jul/14 20:14
• Resolved: 27/Jun/14 12:09

Description

LogFactory checks for the existence of Thread#getContextClassLoader every time
#getLogFactory is invoked and does a reflective invocation. This is
unnecessarily expensive if many Log objects are created. An easy patch is to
remember the Method object; the lookup happens only once and it will massively
profit from reflection optimizations after a number of calls (a Java code stub
is generated by the reflection package).

Patch:

419a420,426
> private static Method GET_CONTEXT_CLASS_LOADER = null;
> static {
> try

{ > GET_CONTEXT_CLASS_LOADER = Thread.class.getMethod("getContextClassLoad er", null); > }

catch (NoSuchMethodException e)

{ > }

> }
436,439c443
< try {
< // Are we running on a JDK 1.2 or later system?
< Method method = Thread.class.getMethod("getContextClassLoader", nu
ll);
<
—
> if(GET_CONTEXT_CLASS_LOADER != null)

{ 442c446 < classLoader = (ClassLoader)method.invoke(Thread.currentThread( ), null); --- > classLoader = (ClassLoader)GET_CONTEXT_CLASS_LOADER.invoke(Thr ead.currentThread(), null); 472c476 < }

catch (NoSuchMethodException e)

{ --- > }

else {