[LOGCXX-84] Problems with stream logging in UTF8, no WCHAR_T build

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.10.0
• Component/s: Build
• Environment: Windows XP, Visual Studio 2005, CVS log4cxx build with UTF8
• Assignee: Curt Arnold
• Reporter: Chris Storah
• Created: 13/May/05 21:29
• Updated: 08/Nov/07 22:04
• Resolved: 08/Nov/07 22:04

Description

log4cxx dll built with log4cxx.h set to:
#define LOG4CXX_LOGCHAR_IS_UTF8 1
#define LOG4CXX_HAS_WCHAR_T 0

Build fails due to encode/decode missing. Changed unicodehelper.cpp+95 from:
#if defined(_WIN32)
unsigned int UnicodeHelper::decodeWide(const wchar_t*& src, const wchar_t* srcEnd) {

to

#if LOG4CXX_HAS_WCHAR_T && defined(_WIN32)
unsigned int UnicodeHelper::decodeWide(const wchar_t*& src, const wchar_t* srcEnd) {

build worked, but when a client uses the library, it crashes when trying to destroy the string being streamed if not a std::string type (i.e. char). See 'logstr2 << "Testing stream" << LOG4CXX_ENDMSG' line in sample below.

Note, this is with 'inline' added to stream.h

Chris

Sample code:

#include "stdafx.h"
#include "Windows.h"
#include <conio.h>

log4cxx::LoggerPtr logger;
log4cxx::logstream* logstr;

int _tmain(int argc, _TCHAR* argv[])
{
logger = log4cxx::Logger::getRootLogger();
log4cxx::PropertyConfigurator::configureAndWatch(log4cxx::File("log.cfg"));

log4cxx::logstream logstr2(logger, log4cxx::Level::getError());
logstr = &logstr2;

LOG4CXX_DEBUG(logger, "Starting tests");

int count = 0;
while (!_kbhit())

{ count++; LOG4CXX_INFO(logger, "info message"); LOG4CXX_DEBUG(logger, "debug message"); LOG4CXX_ERROR(logger, "error message"); LOG4CXX_FATAL(logger, "fatal message"); // this works std::string tmp = "Testing stream, count="; logstr2 << tmp << count << LOG4CXX_ENDMSG; (*logstr) << tmp << count << LOG4CXX_ENDMSG; // this works logstr2 << std::string("Testing stream") << LOG4CXX_ENDMSG; // this fails logstr2 << "Testing stream" << LOG4CXX_ENDMSG; Sleep(1000); // wait 1 second }

LOG4CXX_DEBUG(logger, "Stopped tests");

printf("Press Q and RETURN\n");
scanf("%d");

return 0;
}