log4cxx-0.9.8 release

• Key: LOGCXX-62
• Type: Task
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Curt Arnold
• Reporter: Curt Arnold
• Fix Version/s: 0.10.0

Description

Prepare log4cxx-0.9.8. Add a dependency link to any task that needs to occur before log4cxx-0.9.8 is released.

Comments

[Curt Arnold]

Changing version designation to 0.10.0. 0.9.8 would imply binary compatibility with 0.9.7.

[Renny Koshy]

The "ant" build doesn't work on Solaris 8 with Sun One Studio
================================================
It gives errors about nested comments in the project element. I also noticed that ant thinks we're trying to build on Windows. The command I used was:

ant -Dapr.dir=/export/home/renny/apr-1.2.12 -Dapr-util.dir=/export/home/renny/apr-util-1.2.12 -Dcompiler=CC -Ddebug=true

This is with the latest ant.

[Renny Koshy]

Most of the headers that use LOG4CXX_PTR_DEF have a semicolon (;) following the invocation of that macro -- FAILS on Solaris 8 + Sun One Studio
===================================================================================================================
Unfortunately, Sun Studio sees this as an error, and stops. I fixed it by running the following command, which removed the semi-colon following the invocation of the macro. I also noticed that some files already had the correct usage.

find . -name \*.h|xargs grep -l "PTR_DEF.*;$"| xargs -i -t perl -i -p -e "s/(PTR_DEF[^;]*);$/\1/" {}

The only one that was missed was smtpappender.h, which apparently has lots of spaces after the invokation, thereby causing my search/replace to fail on it (I had not antcipated that). So I manually edited the file:
src/main/include/log4cxx/net/smtpappender.h

[Renny Koshy]

Additional fixes needed for Solaris + Sun One Studio... since the STL implementation has issues returning the template param for has_facet and use_facet:

diff -r apache-log4cxx-0.10.0/src/main/cpp/simpledateformat.cpp /export/home/renny/apache-log4cxx-0.10.0/src/main/cpp/simpledateformat.cpp
45a46
> #ifndef _RWSTD_NO_TEMPLATE_ON_RETURN_TYPE
47a49,52
> #else
> #define HAS_FACET(locale, type) std::has_facet(locale,(type *)0)
> #define USE_FACET(locale, type) std::use_facet(locale,(type *)0)
> #endif

diff -r apache-log4cxx-0.10.0/src/test/cpp/helpers/datetimedateformattestcase.cpp /export/home/renny/apache-log4cxx-0.10.0/src/test/cpp/helpers/dat
etimedateformattestcase.cpp
187a188
> #ifndef _RWSTD_NO_TEMPLATE_ON_RETURN_TYPE
189a191,194
> #else
> std::use_facet(locale,(std::time_put<logchar> *)0)
> .put(buffer, buffer, buffer.fill(), &date, fmt.c_str(), fmt.c_str() + fmt.length());
> #endif

[Curt Arnold]

Apache log4cxx 0.10.0 released 3 April 2008