Issue Details (XML | Word | Printable)

Key: LOGCXX-54
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Curt Arnold
Reporter: Curt Arnold
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Log4cxx

Eliminate use of boost-regex in unit tests

Created: 29/Jan/05 02:02 AM   Updated: 06/Feb/05 11:02 AM
Return to search
Component/s: None
Affects Version/s: 0.9.7
Fix Version/s: 0.10.0

Time Tracking:
Not Specified

Resolution Date: 06/Feb/05 11:02 AM


 Description  « Hide
The unit tests in 0.9.7 used boost Regular Expressions (http://www.boost.org) to eliminate variable parts (dates, thread ids, etc) of generated log files. While this was efficient and parallels the use of jakarta-oro in log4j, it substantially increased the complexity of configuring a system to run the unit tests. If this approach had been continued, it would be highly unlikely to run the unit tests on Gump since getting boost-regex to build on Gump would require substantial effort to add the boost specific build tools (bjam) to the tools supported by Gump.

The approach to eliminate the dependency on boost-regex is to use APR's apr_proc_create to execute sed assumed to be in the path. Currently ControlFilter (which checked that each log line matched at least one of a set of regular expressions) is effectively a no-op, however since each file appears to be compared against a witness file, the added check with a ControlFilter may be unnecessary.

The initial commit will build, run but fails some tests, I'll fix that on a different platform.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #308744 Fri Jan 28 17:03:38 UTC 2005 carnold LOGCXX-54: Eliminate use of boost-regex with sed
Files Changed
MODIFY /logging/log4cxx/trunk/tests/src/util/xmllineattributefilter.h
MODIFY /logging/log4cxx/trunk/src/ndc.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/linenumberfilter.cpp
MODIFY /logging/log4cxx/trunk/src/socketinputstream.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/filter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/linenumberfilter.h
MODIFY /logging/log4cxx/trunk/tests/src/net/socketservertestcase.cpp
MODIFY /logging/log4cxx/trunk/include/log4cxx/file.h
MODIFY /logging/log4cxx/trunk/tests/src/util/absolutetimefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/filter.h
MODIFY /logging/log4cxx/trunk/src/loggingevent.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/filenamefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/iso8601filter.cpp
MODIFY /logging/log4cxx/trunk/src/mutex.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/absolutetimefilter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/threadfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/filenamefilter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/iso8601filter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/threadfilter.h
MODIFY /logging/log4cxx/trunk/build.xml
MODIFY /logging/log4cxx/trunk/tests/src/util/relativetimefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/relativetimefilter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/xmltimestampfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/asyncappendertestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/controlfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/xmlfilenamefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/absolutedateandtimefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/xmltimestampfilter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/xmlthreadfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/controlfilter.h
MODIFY /logging/log4cxx/trunk/tests/src/xml/xmllayouttestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/patternlayouttest.cpp
MODIFY /logging/log4cxx/trunk/tests/src/xml/domtestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/xmlfilenamefilter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/absolutedateandtimefilter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.h
MODIFY /logging/log4cxx/trunk/tests/src/util/xmlthreadfilter.h
MODIFY /logging/log4cxx/trunk/tests/src/minimumtestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/varia/errorhandlertestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/xmllineattributefilter.cpp

Repository Revision Date User Message
ASF #308745 Sat Jan 29 17:43:45 UTC 2005 carnold LOGCXX-54: Replace boost-regex with sed
Files Changed
MODIFY /logging/log4cxx/trunk/tests/src/util/filter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.cpp
MODIFY /logging/log4cxx/trunk/build.xml
MODIFY /logging/log4cxx/trunk/tests/src/patternlayouttest.cpp
MODIFY /logging/log4cxx/trunk/tests/src/xml/domtestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/minimumtestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/varia/errorhandlertestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/linenumberfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/xmltimestampfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/xmllineattributefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/net/socketservertestcase.cpp

Repository Revision Date User Message
ASF #308746 Sat Jan 29 23:44:54 UTC 2005 carnold LOGCXX-54: Replacement of boost-regex with sed
Files Changed
MODIFY /logging/log4cxx/trunk/build.xml
MODIFY /logging/log4cxx/trunk/tests/src/util/linenumberfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/witness/patternLayout.8
MODIFY /logging/log4cxx/trunk/tests/src/util/xmltimestampfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/xmlfilenamefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/net/socketservertestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/filter.h
MODIFY /logging/log4cxx/trunk/tests/src/util/xmlthreadfilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.cpp
MODIFY /logging/log4cxx/trunk/tests/src/xml/xmllayouttestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/xml/domtestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/patternlayouttest.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/filenamefilter.cpp
MODIFY /logging/log4cxx/trunk/tests/src/minimumtestcase.cpp
MODIFY /logging/log4cxx/trunk/tests/src/varia/errorhandlertestcase.cpp
MODIFY /logging/log4cxx/trunk
MODIFY /logging/log4cxx/trunk/.cvsignore
MODIFY /logging/log4cxx/trunk/tests/src/util/xmllineattributefilter.cpp

Repository Revision Date User Message
ASF #308750 Fri Feb 04 07:07:01 UTC 2005 carnold LOGCXX-54: boost-regex replacement still not quite working
Files Changed
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.cpp

Repository Revision Date User Message
ASF #308751 Fri Feb 04 07:51:52 UTC 2005 carnold LOGCXX-54: Looks like sed is working now
Files Changed
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.cpp
MODIFY /logging/log4cxx/trunk/msvc/log4cxx.sln

Repository Revision Date User Message
ASF #308752 Fri Feb 04 08:49:08 UTC 2005 carnold LOGCXX-54: fixed default target
Files Changed
MODIFY /logging/log4cxx/trunk/build.xml

Repository Revision Date User Message
ASF #308768 Thu Feb 10 19:40:14 UTC 2005 carnold LOGCXX-54: Remove echo of sed command to console
Files Changed
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.cpp

Repository Revision Date User Message
ASF #308806 Thu Mar 10 19:47:41 UTC 2005 carnold LOGCXX-54: avoid sed -i not supported on Mac
Files Changed
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.cpp
MODIFY /logging/log4cxx/trunk/tests/src/util/transformer.h

Repository Revision Date User Message
ASF #351783 Fri Dec 02 18:00:13 UTC 2005 afester LOGCXX-54: additional build tweak to remove obsolete boost-regex library dependency
Files Changed
MODIFY /logging/log4cxx/trunk/configure.in