Missing #else

• Key: LOGCXX-3
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Curt Arnold
• Reporter: Inge K. Eliassen
• Component/s: Build
• Fix Version/s: 0.10.0

Description

In file thread.cpp the function Thread::InterlockedIncrement is missing an #else directive:

-------------------------- from Thread.cpp------------------------------
#elif defined(HAVE_MS_THREAD)
#if _MSC_VER == 1200 // MSDEV 6
return ::InterlockedDecrement((long *)val);
#else
return ::InterlockedDecrement(val);
#endif // _MSC_VER
#else /****** Without this line the function does not return a value
return *val - 1; // unsafe
#endif
------------------------------------------------------------------------

Also: should not the #else case be
   return --(*val) ?
As it stands now *val is left unchanged...


Similarly for function Thread::InterlockedDecrement.

Comments

[Curt Arnold]

log4cxx now uses Apache Portable Runtime for threading and the code mentioned is no longer in codebase.