[LOGCXX-128] Passing invalid argument to ::putenv function

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 0.9.7
• Fix Version/s: 0.10.0
• Environment: Linux
• Assignee: Curt Arnold
• Reporter: Lukasz Heldt
• Created: 10/Feb/06 22:15
• Updated: 11/Feb/06 03:14
• Resolved: 11/Feb/06 03:14

Description

putenv manual states that variable passed to the function will not be copied and will be kept as is. Thus programers should not try to modify it later.
log4cxx does even worse thing - it passes argument which is than deallocated. System uses freed space every time log4cxx functions are called.

timezone.cpp:

TimeZone::TimeZone(const String& ID)
: ID(ID), rawOffset(0), DSTSavings(0)
{
String timeZoneEnv = _T("TZ=") + ID;

USES_CONVERSION;
::putenv((char *)T2A(timeZoneEnv.c_str()));

...
}
// at this point timeZoneEnv.c_str() is deleted but still kept and referenced in programs environment

Bug can be easly spotted using valgrind software.