[#LOG4NET-73] ADONetAppender.ActivateOptions() leaks database connection when called multiple times

Log4net

ADONetAppender.ActivateOptions() leaks database connection when called multiple times

Created: 27/Mar/06 07:30 AM Updated: 27/Mar/06 09:58 PM

Return to search

Component/s:

Appenders

Affects Version/s:

1.2.9

Fix Version/s:

1.2.10

Time Tracking:

Not Specified

Resolution Date:

27/Mar/06 09:58 PM

Description

« Hide

ADONetAppender.ActivateOptions() calls InitializeDatabaseConnection. This method does not check if the m_dbConnection is already initialised. If it is initialise then it will beleaked.

Update InitializeDatabaseConnection to check and close the connection if not null.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#389130	Mon Mar 27 12:57:23 UTC 2006	nicko	Fix for ~~LOG4NET-73~~. Added code to cleanup the connection and command objects that are stored in members if the InitializeDatabaseConnection method is called multiple times.
				Files Changed
				MODIFY /logging/log4net/trunk/src/Appender/AdoNetAppender.cs

Nicko Cadell made changes - 27/Mar/06 05:38 PM

Field	Original Value	New Value
Summary	ADONetAppender.ActivateOptions() database Connection Leak is called multiple times	ADONetAppender.ActivateOptions() leaks database connection when called multiple times

[ Permlink | « Hide ]

Nicko Cadell added a comment - 27/Mar/06 09:58 PM

Added code to cleanup the connection and command members if the InitialiseDatabaseConnection method is called multiple times.

Nicko Cadell made changes - 27/Mar/06 09:58 PM

Fix Version/s		1.2.10 [ 11128 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]