[#LOG4NET-72] Performance of ILog.xxxFormat methods

Log4net

Performance of ILog.xxxFormat methods

Created: 25/Mar/06 01:17 AM Updated: 30/Mar/06 12:04 AM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

1.2.10

Time Tracking:

Not Specified

Resolution Date:

30/Mar/06 12:04 AM

Description

« Hide

The performance of the ILog.xxxFormat methods can be improved.

1) Add method overloads for common numbers of arguments:

void DebugFormat(string format, object arg0);
void DebugFormat(string format, object arg0, object arg1);
void DebugFormat(string format, object arg0, object arg1, object arg2);

2) Delay formatting of the message until after the appenders filters have run.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Nicko Cadell made changes - 25/Mar/06 02:18 AM

Field	Original Value	New Value
Assignee		Nicko Cadell [ nicko ]

Repository	Revision	Date	User	Message
ASF	#389152	Mon Mar 27 14:10:19 UTC 2006	nicko	Fix for ~~LOG4NET-72~~. Moved String.Format call into separate class SystemStringFormat. This class holds the format string and arguments and only performs the String.Format when its ToString method is called. Added simple test to ensure that the String.Format methods are working correctly and error handling correctly. Updated the tests project nant.build to copy shared libs into the build output directory.
				Files Changed
				MODIFY /logging/log4net/trunk/tests/src/log4net.Tests.csproj ADD /logging/log4net/trunk/src/Util/SystemStringFormat.cs MODIFY /logging/log4net/trunk/tests/nant.build MODIFY /logging/log4net/trunk/src/Core/LogImpl.cs MODIFY /logging/log4net/trunk/src/log4net.csproj MODIFY /logging/log4net/trunk/src/Util/Transform.cs ADD /logging/log4net/trunk/tests/src/Core/StringFormatTest.cs ADD /logging/log4net/trunk/tests/lib ADD /logging/log4net/trunk/tests/lib/prerequisites.txt

Repository	Revision	Date	User	Message
ASF	#389802	Wed Mar 29 14:32:04 UTC 2006	nicko	Fix for ~~LOG4NET-72~~. Added overloaded Format methods for 1, 2, and 3 fixed arguments. This is a performance enhancement.
				Files Changed
				MODIFY /logging/log4net/trunk/src/Core/LogImpl.cs MODIFY /logging/log4net/trunk/tests/src/Core/StringFormatTest.cs MODIFY /logging/log4net/trunk/src/ILog.cs

Repository	Revision	Date	User	Message
ASF	#389808	Wed Mar 29 14:57:27 UTC 2006	nicko	Fix for ~~LOG4NET-72~~. CultureInfo.GetCultureInfo is not supported on .net 1.0 and 1.1
				Files Changed
				MODIFY /logging/log4net/trunk/tests/src/Core/StringFormatTest.cs

[ Permlink | « Hide ]

Nicko Cadell added a comment - 30/Mar/06 12:04 AM

Checked in code to resolve this issue

Nicko Cadell made changes - 30/Mar/06 12:04 AM

Fix Version/s		1.2.10 [ 11128 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]