AdoNetAppender losing first entry

• Key: LOG4NET-32
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Nicko Cadell
• Reporter: Richard Gee
• Component/s: Appenders
• Affects Version/s: 1.2.9
• Fix Version/s: 1.2.10

Environment

VB.Net 2003, .Net 1.1.4322 SP1, SQL Server 2000, Windows XP Pro

Description

AdoNetAppender is losing the first log entry, caused by the entry being discarded as the underlying buffer cycles for the first time.

Probable error at line 400 in BufferingAppenderSkeleton.cs:

if (discardedLoggingEvent != null && m_lossyEvaluator != null && m_lossyEvaluator.IsTriggeringEvent(discardedLoggingEvent))

If you don't give a lossy evaluator the event is discarded, regardless of whether the buffer is lossy or not. This line should also check if the buffer is lossy, and send the discarded event if it isn't:

if (discardedLoggingEvent != null && (!m_lossy || (m_lossyEvaluator != null && m_lossyEvaluator.IsTriggeringEvent(discardedLoggingEvent))))